From: "Danilo Krummrich" <dakr@kernel.org>
To: "Onur Özkan" <work@onurozkan.dev>
Cc: <tj@kernel.org>, <jiangshanlai@gmail.com>, <aliceryhl@google.com>,
<ojeda@kernel.org>, <boqun@kernel.org>, <gary@garyguo.net>,
<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
<a.hindborg@kernel.org>, <tmgross@umich.edu>,
<daniel.almeida@collabora.com>, <tamird@kernel.org>,
<acourbot@nvidia.com>, <jhubbard@nvidia.com>,
<rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<driver-core@lists.linux.dev>
Subject: Re: [PATCH 6/7] rust: workqueue: add Work::cancel_work_sync()
Date: Fri, 07 Aug 2026 13:51:33 +0200 [thread overview]
Message-ID: <DKIOUHFXA1F7.2LO5DQA5XGBNG@kernel.org> (raw)
In-Reply-To: <20260807075141.9294-1-work@onurozkan.dev>
On Fri Aug 7, 2026 at 9:51 AM CEST, Onur Özkan wrote:
> Perhaps you could pull the exiting effort for `cancel_sync` support [1] which
> is also used by the tyr reset implementation [2]?
Please also see my reply to John [3].
I think for your implementation in Tyr you should just use ScopedWork, which
should simplify the implementation significantly.
cancel_sync() for Work could be useful regardless, but it seems to be an
orthogonal effort that requires a separate use-case, so I rather not include it
in this series.
> [1]: https://lore.kernel.org/all/20260617131731.145337-2-work@onurozkan.dev
> [2]: https://lore.kernel.org/all/20260708114358.957305-1-work@onurozkan.dev
[3] https://lore.kernel.org/all/DKIOSPRHO8V1.286KQFRH751TE@kernel.org/
next prev parent reply other threads:[~2026-08-07 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 19:52 [PATCH 0/7] workqueue OwnedQueue, ScopedQueue and ScopedWork Danilo Krummrich
2026-08-04 19:52 ` [PATCH 1/7] rust: workqueue: replace deprecated system_wq with system_{percpu,dfl}_wq Danilo Krummrich
2026-08-04 19:52 ` [PATCH 2/7] rust: workqueue: restrict delayed work to global wqs Danilo Krummrich
2026-08-04 19:52 ` [PATCH 3/7] rust: workqueue: create workqueue subdirectory Danilo Krummrich
2026-08-04 19:52 ` [PATCH 4/7] rust: workqueue: add creation of workqueues Danilo Krummrich
2026-08-04 19:52 ` [PATCH 5/7] rust: workqueue: add ScopedQueue for lifetime bound items Danilo Krummrich
2026-08-04 19:52 ` [PATCH 6/7] rust: workqueue: add Work::cancel_work_sync() Danilo Krummrich
2026-08-07 1:37 ` John Hubbard
2026-08-07 11:49 ` Danilo Krummrich
2026-08-07 7:51 ` Onur Özkan
2026-08-07 11:51 ` Danilo Krummrich [this message]
2026-08-04 19:52 ` [PATCH 7/7] rust: workqueue: add ScopedWork for non-'static work items Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DKIOUHFXA1F7.2LO5DQA5XGBNG@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tj@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox