From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed2-f32.google.com (mail-ed2-f32.google.com [74.125.228.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E936518152 for ; Thu, 1 Oct 2026 14:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.96 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790863694; cv=none; b=J5O6ZUV8KCXuT3ZPw/Bx0p0Gkhjm/NiM0A6iH+GBuChHF5PN59hRBVR83kl2K2E8uvYw3tfmnkxWCDImQyg9s1WQcXnO9bpaVqyx01aKawxAH0cqq7j/+3pz7MskGKmojDQuAauA/FvbTSI39pitNB9pzyDnG0ZoLk9GkQuopL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790863694; c=relaxed/simple; bh=zECpyUBkuoTFGnpwSyLJZls4RBh3ZrxrUUu2x8F+Hms=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=IwJ3gT/mUrbfR2C/Ow00yPXs4zRaZYwRNUNLszXPAdcuugVP5X2e9dtu8KZJog8EmIkbvaqN02AAUd79rUyFlWEd4rPFtrBNScGkpEA8Iu7+tqGKLwhTvu8+44pqqjTf8O2jr0Nl1UJxQFapgAVFr34lFGSx1JNXoyXCBZbJ09w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oRfj7FkH; arc=none smtp.client-ip=74.125.228.96 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oRfj7FkH" Received: by mail-ed2-f32.google.com with SMTP id 4fb4d7f45d1cf-6acaec6a74aso4804901a12.2 for ; Thu, 01 Oct 2026 07:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790863691; x=1791468491; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=zECpyUBkuoTFGnpwSyLJZls4RBh3ZrxrUUu2x8F+Hms=; b=oRfj7FkHiu21TkuJzLEjQ1WBZAQCtT34TaAQiM70+g81xaqgv4HrCXysAoxBMuNWvE n78oFjsZPhERWcCpn0GIfGfM3n2/cwzJrWDMhl1Ok9m0M9zCJxUW6I6ofQghh/RrL/Di FQ3H3lbnZXxCd/EiIVVPf1PyJ5Fx5cnZ2AFLxYFaE1HJKRmPssvs9Xkkb7+Z+4yggMKj k20P6SEwcqJKc9EgxyuIWnN4Yr+4subazOAxjj6BmRlqdIkmeGDS5yXqUf52guMhngh7 SggepNmp4yBLjZxCDGd4UQJ8ITJfGhRqOvLrjIhV9wgVBun75ZGzFHN+TrzHdHz/UZbC wZLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790863691; x=1791468491; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zECpyUBkuoTFGnpwSyLJZls4RBh3ZrxrUUu2x8F+Hms=; b=mlqVUPaOzKF2dzjZlEWgKbBvAj8XOilixfU4A18NeQOZYLQL4RF0xHV+Gi2u5qIaAj c08GIlmolyZA8qSwyemAO817uT8uZeROD/hv2OJxm7twccklsIR0izB5gAyZpuNjhxnU uhFZAQ6Yz0FPLAGF1vu/yASCWUZQ8T41+/mhBcskwZzhBNeTkfQD4aUAy3DaAqoBVcr/ yyCglZROx2iaeR1WoCJ6VZT2GTvqTYsG439KL9NgO0ymMjUbkQtIVx4iu9h3+NPezMnZ Oyu0W20NdZ7XVneS4koItqW+PvGL2v5o+oUxqbno1fehYGxMW6ZUwLvGduYR3clAiKuR uwXw== X-Forwarded-Encrypted: i=1; AKwUvByZnRt/DHlmyUxITUa+Z6r2FAwc5Y2SkjxEFjX7g2BNrCySmrHsum26d3cAk/lILe1SU3MNTd23M6TQmKC58g==@vger.kernel.org X-Gm-Message-State: AFq9FYL2IqD0xjZrUjBtFD/GheybVjXw0owBxn86UIOvK1dWVRv8q/Zz qecGUcPBtv0hsMWjLBJlJ3DDrIQTnnZSXPptZgUiaES2dynlgWhi2N0= X-Gm-Gg: AYBFou0ugdIW47dsDpalMhE6xShybtSr08xrOEoe/8xCMUUJdhaEKX1SJtBsLAEJ4P0 ri5JiwfYL8axN0gt7S9sAMhke/bUY9yXdBcKibbrv4VKNsbo/p+ShgWSfOCgtGyFxJyhqds1Ula +SPB9AdI3bZj+qAyKmU1b/y6uIlKBW2+BvfWx/7sPuRKMA5vtwbBxxQEb52YgE25EFVm7MnR0Q7 PDyQdbhxaLUst4X9mIFnWu/cX+ZIgqBOlrP0Y0zTmsNW0OnBqYEfoyvlia6ZMC6Ryo2Lb+WhlhY +AtOx24aI4M58JVr5Kx/OsrqdAstNpc0t5UX20J0PtR/Cpw6PtaFg3SAklCdqURE39+9SXzpbrW Av2CovlkcVZR864U5M130MSz7HLw3elcsE/+WNgKlM49JGngEF4CSIFJjEDxDBcY5fD2RcJb0LG 6Vrt+tEPoU2+rFNBXHMG80TXhFEMvcVCN3bCOwIvVVQpWHmMzdrsNqIswENMaLo1i7UiaAM+E6I Chp4MOfrCG4jfhteym+1ctVgS2Nd5lXDjn4JAMVGbR9 X-Received: by 2002:a05:6402:52cf:b0:6ac:c4fd:c726 with SMTP id 4fb4d7f45d1cf-6ae1995216dmr3927218a12.42.1790863690562; Thu, 01 Oct 2026 07:08:10 -0700 (PDT) Received: from localhost ([186.158.238.108]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6ae5ca76374sm1111911a12.30.2026.10.01.07.08.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2026 07:08:09 -0700 (PDT) Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 01 Oct 2026 11:08:00 -0300 Message-Id: Cc: "Alexandre Courbot" , "Andreas Hindborg" , "Benno Lossin" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Boqun Feng" , "Brigham Campbell" , "Daniel Almeida" , "Danilo Krummrich" , "Jori Koolstra" , =?utf-8?q?Onur_=C3=96zkan?= , "Rae Moar" , "Shuah Khan" , "Tamir Duberstein" , "Trevor Gross" , "Yury Norov" , , , Subject: Re: [PATCH 0/3] rust: kunit: support #[should_panic] and same test name with different #[cfg(...)] From: =?utf-8?q?Nicol=C3=A1s_Antinori?= To: "Gary Guo" , "Alice Ryhl" , "Burak Emir" , "Brendan Higgins" , "David Gow" , "Miguel Ojeda" X-Mailer: aerc 0.20.0 References: <20260930-rust_kunit_v4-v1-0-e3b0d45311dd@gmail.com> In-Reply-To: On Wed Sep 30, 2026 at 11:54 AM -03, Gary Guo wrote: > On Wed Sep 30, 2026 at 2:23 PM BST, Nicol=C3=A1s Antinori via B4 Relay wr= ote: >> This patch series intends to implement two features for KUnit tests >> written in Rust. The work is based on a TODO comment made in the >> `bitmap.rs` module [1]. >> >> Changelog: >> - RFC patch: [3] >> >> 1. Supporting `#[should_panic]` [2]: >> >> KUnit tests in Rust follow the user-space syntax, but at the moment >> `#[should_panic]` is not supported. The first patch of this series adds >> support for the attribute (only in its basic form, `#[should_panic =3D >> "message"]` is not supported yet). >> >> The way it is supported is by adding a new boolean property called >> `rust_should_panic` to `kunit_attributes` struct in kunit/test.h and > > This is now more general than Rust panics? Perhaps this should just be > "should_bug"? I used the name suggested by David Gow in the RFC Patch [1]. I believe "should_panic" is better because it directly matches the attribute name and will stay consistent in case the panic handler changes the way it trigger kernel panics (although this is very unlikely I think). That said, I'd be happy to change it to should_bug if that is preferred, please let me know what you think! Best regards, Nicol=C3=A1s=20 [1] https://lore.kernel.org/rust-for-linux/d20cc2b2-afeb-432c-924b-55ad00d9= 80fe@davidgow.net/