From: "Gary Guo" <gary@garyguo.net>
To: "Benno Lossin" <lossin@kernel.org>, <gary@garyguo.net>
Cc: <a.hindborg@kernel.org>, <acourbot@nvidia.com>,
<aliceryhl@google.com>, <bjorn3_gh@protonmail.com>,
<boqun@kernel.org>, <dakr@kernel.org>,
<daniel.almeida@collabora.com>, <linux-kernel@vger.kernel.org>,
<ojeda@kernel.org>, <rust-for-linux@vger.kernel.org>,
<tamird@kernel.org>, <tmgross@umich.edu>, <work@onurozkan.dev>
Subject: Re: [PATCH 0/8] rust: pin-init: various cleanups to prepare for self-reference
Date: Wed, 07 Oct 2026 14:36:39 +0200 [thread overview]
Message-ID: <DLYM08Y3B909.2AJAKJP0VBP77@garyguo.net> (raw)
In-Reply-To: <20261007102045.1593329-1-lossin@kernel.org>
On Wed Oct 7, 2026 at 12:20 PM CEST, Benno Lossin wrote:
> On 06 Oct 2026 17:29:30 +0200, Gary Guo <gary@garyguo.net> wrote:
>> Pin-init self reference is going to be a big feature, touching various
>> places in pin_data and init macros. Do some various cleanups to tidy up the
>> macro codebase, so the feature can land without much refactoring.
>>
>> Details in commits.
>>
>> Signed-off-by: Gary Guo <gary@garyguo.net>
>> ---
>> Gary Guo (8):
>> rust: pin-init: internal: init: forget guards in reverse order
>> rust: pin-init: internal: init: set span location of guards
>> rust: pin-init: internal: add utility to handle generics merging
>> rust: pin-init: internal: add utility for extract a single attribute
>> rust: pin-init: internal: pin_data: move projection struct into `const _: ()` block
>> rust: pin-init: internal: pin_data: extract `#[cfg]` processing to its own function
>> rust: pin-init: internal: pin_data: rename `'__pin` lifetime to `'__this`
>> rust: pin-init: internal: pin_data: parse into `StructInfo` before generating
>>
>> rust/pin-init/internal/src/init.rs | 19 +--
>> rust/pin-init/internal/src/lib.rs | 3 +-
>> rust/pin-init/internal/src/pin_data.rs | 217 +++++++++++++++++++++------------
>> rust/pin-init/internal/src/util.rs | 189 +++++++++++++++++++++++++++-
>> 4 files changed, 341 insertions(+), 87 deletions(-)
>
> these are good improvements. looking forward to seeing the self-ref here!
>
> Acked-by: Benno Lossin <lossin@kernel.org>
Thanks, applied to pin-init-next now.
FWIW, Sashiko's suggestion doesn't apply -- unit struct was never supported, and
cfg for generics are not supported either (and not handled by syn's
impl/ty_generics impl).
Best,
Gary
prev parent reply other threads:[~2026-10-07 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 15:29 [PATCH 0/8] rust: pin-init: various cleanups to prepare for self-reference Gary Guo
2026-10-06 15:29 ` [PATCH 1/8] rust: pin-init: internal: init: forget guards in reverse order Gary Guo
2026-10-06 15:29 ` [PATCH 2/8] rust: pin-init: internal: init: set span location of guards Gary Guo
2026-10-06 15:29 ` [PATCH 3/8] rust: pin-init: internal: add utility to handle generics merging Gary Guo
2026-10-06 15:29 ` [PATCH 4/8] rust: pin-init: internal: add utility for extract a single attribute Gary Guo
2026-10-06 15:29 ` [PATCH 5/8] rust: pin-init: internal: pin_data: move projection struct into `const _: ()` block Gary Guo
2026-10-06 15:29 ` [PATCH 6/8] rust: pin-init: internal: pin_data: extract `#[cfg]` processing to its own function Gary Guo
2026-10-06 15:29 ` [PATCH 7/8] rust: pin-init: internal: pin_data: rename `'__pin` lifetime to `'__this` Gary Guo
2026-10-06 15:29 ` [PATCH 8/8] rust: pin-init: internal: pin_data: parse into `StructInfo` before generating Gary Guo
2026-10-07 10:20 ` [PATCH 0/8] rust: pin-init: various cleanups to prepare for self-reference Benno Lossin
2026-10-07 12:36 ` Gary Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLYM08Y3B909.2AJAKJP0VBP77@garyguo.net \
--to=gary@garyguo.net \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox