Rust for Linux List
 help / color / mirror / Atom feed
From: "Gary Guo" <gary@garyguo.net>
To: "Alice Ryhl" <aliceryhl@google.com>,
	"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Sami Tolvanen" <samitolvanen@google.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nsc@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	"kernel test robot" <yi1.lai@intel.com>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	rust-for-linux@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] rust: cfi: disable function merging if CFI is enabled
Date: Wed, 18 Nov 2026 11:25:46 +0000	[thread overview]
Message-ID: <DMYASURCURHG.2Z417FHDGBR5F@garyguo.net> (raw)
In-Reply-To: <avy_9SPRaPSKD8b4@google.com>

On Tue Nov 17, 2026 at 8:58 PM GMT, Alice Ryhl wrote:
> On Fri, Aug 21, 2026 at 11:20:18AM +0200, Miguel Ojeda wrote:
>> On Fri, Aug 21, 2026 at 1:43 AM Sami Tolvanen <samitolvanen@google.com> wrote:
>> >
>> > The LLVM fix itself is trivial, and it looks like a pull request for
>> > it already exists. I assume we'll want to drop this flag for fixed
>> > LLVM versions when they're available.
>> 
>> I will link it in the commit message when I pick it up soon -- already
>> did in https://github.com/Rust-for-Linux/linux/issues/1132.
>> 
>> I also added the `-Z` flag to https://github.com/Rust-for-Linux/linux/issues/2.
>> 
>> The `-Zmerge-functions` flag is internal but has been there since Rust
>> 1.34.0 in upstream commit:
>> 
>>   b91d211b4030 ("Add a target option "merge-functions" taking values
>> in ("disabled", "trampolines", or "aliases (the default)) to allow
>> targets to opt out of the MergeFunctions LLVM pass. Also add a
>> corresponding -Z option with the same name and values.")
>> 
>> so that should be fine, but I will ping upstream Rust so that they are
>> aware we are using it.
>> 
>> And, yeah, agreed, we probably should remove the flag conditionally
>> later on, to confirm the bug is gone etc.
>
> Function merging should also be disabled with gendwarfksyms. It causes
> faux::Registration::as_raw() and Page::as_ptr() to get merged, which
> incorrectly causes the former to get the CRC of the latter.

Do we not want merging at all, or only when the types are not going to match up?
If somehow the KCFI type metadata is always emitted, will two functions with the
same KCFI type metadata be mergeable for gendwarfksyms purpose?

Best,
Gary


  parent reply	other threads:[~2026-11-18 11:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 13:57 [PATCH] rust: cfi: disable function merging if CFI is enabled Gary Guo
2026-08-20 15:58 ` Gary Guo
2026-08-20 23:42   ` Sami Tolvanen
2026-08-21  9:20     ` Miguel Ojeda
2026-11-17 20:58       ` Alice Ryhl
2026-11-17 22:03         ` Sami Tolvanen
2026-11-18  9:57           ` Alice Ryhl
2026-11-18 11:25         ` Gary Guo [this message]
2026-11-18 11:52           ` Alice Ryhl
2026-08-24  1:15 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMYASURCURHG.2Z417FHDGBR5F@garyguo.net \
    --to=gary@garyguo.net \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=justinstitt@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=lossin@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nsc@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    --cc=yi1.lai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox