From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795106296; b=dCjMUSKPnkWFz+XRm6X5DLF3xOnghIfStWrqMcZLk+g90EJndflfh8ThjgLsvJRRe0BO 0GWG9c5sT3n3qPCEuUT1sqSbh/ASrKNws2FsxSjGjrw4weVaph/qnkInDpQt/KnUeOgxt xIu9p7H6VbgfGckacbDFKONXkviv338WbtettUWLgXHUm5AGk64CheF84E8x/n+oSEZQX YZHnMa2qgunf8OUl0WZ8hFv7055+lWm5cljanBiEjv1yb5KR714xhds+23fMWf0LIfsK/ NpSiOkWpmWP7CjKofYhWbKUq5US/I2lRsPr4xo02ly45e0RRyl5iREGAF3jFvoxtBAQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795106296; h=Received:DKIM-Signature:Mime-Version:Content-Transfer-Encoding: Content-Type:Date:Message-Id:Subject:Cc:To:From:References: In-Reply-To; bh=Qnkd9IzUfJL6pRotEqKRjb0AkZ6zIZR7+fouUqriiqA=; b=qh8bx+4WJD3UmEjco7jkP9ipmSPWHLlkIbYoNAJ/cYfXdgY5C/po2Aia0LMrf/Te+2Fh I8Mb9pn5H1UVkg+jgfWkE/kJ/DSlbfz96fKi12w3DyzsHFUkntGqwuXJ8t117znvKbCn+ d+2kHwJ1SML2PPeimM+nrX+QGZl9YfIDl+UiyScT+apee7eWuWKztGzdsdvzwrvL+VpcY zwhrDhBgUhmYlPwq+aMxoIYmtgxSTVIFWy8bzYGw9O2+nf5x7/fwK2ni/9kWHS3YJ4jMU 7m4xY92najq3pfI7Ou2BzbEdL6v9aqgbFEG2d8xGXc28Tjm8aODhxXLocAyh+IyfMlA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XRNGci51; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE717606A324; Thu, 19 Nov 2026 16:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XRNGci51 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6986C1F000C4; Thu, 19 Nov 2026 16:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795106296; bh=Qnkd9IzUfJL6pRotEqKRjb0AkZ6zIZR7+fouUqriiqA=; h=Date:Subject:Cc:To:From:References:In-Reply-To; b=XRNGci51SIE3oHtCwVfNl9mHrt8swIeharTSKW7ZEipwvJPmMMTY/u4m+xSmybe81 0e1jremmE+JIRXM1/gEcx5D5ALBVbPsBj28iDjBk0WA7amgdTeg0XyjR6PIOai6faU LXz5B0JhwzqbdsNiUahHS4zU7j15/4hgD1KL43ptpqkXjPUHJun4YO1K1TUtUlcvsH JUMDEEukfO0SrO+IIcSmxHzy0ZjsSLmDruuQQHg6AlKlJzVUY1tvApUjOBeKOjoI79 ruskHQz5joYYEGC0V/pIRZG+99xpE4Jqa4qSemjidlwvh5HdFpOLC/lNX1jCSFy6kM IpOdMESLGtPdg== X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 19 Nov 2026 17:38:11 +0100 Message-Id: Subject: Re: [PATCH 1/4] drm/tyr: name resource lifetimes after their types Cc: "Gary Guo" , , , , , , , , , , , , , , , To: "Alice Ryhl" From: "Danilo Krummrich" References: <20261118233727.3147222-1-dakr@kernel.org> <20261118233727.3147222-2-dakr@kernel.org> <20261119154430.918072-1-aliceryhl@google.com> In-Reply-To: <20261119154430.918072-1-aliceryhl@google.com> On Thu Nov 19, 2026 at 4:44 PM CET, Alice Ryhl wrote: > On Thu, Nov 19, 2026 at 02:57:37PM +0100, Danilo Krummrich wrote: >> I think in the end it comes down to personal preference, so this is fine= with me >> too. >> >> Though, I'd use a generic name in the latter case too, such that it does= n't need >> to be changed once a second resource is referenced later on. > > Agreed, using a generic name like `'a` (or borrowed-resource names for > invariant lifetimes) sounds good to me too. > > Also, when updating this for v2, note that `VmAsData<'drm>` in > `mmu/address_space.rs` and `GpuVmData<'drm>` (along with `VmMapArgs`, > `VmOpType`, `VmOpResources`, `VmOpRequest`, and `PtUpdateContext` in > `vm.rs`) were still left using `'drm`. Before I respin I'll wait for Gary to look into how the existential lifetim= e could be moved to Vm (which is what I considered initially, but couldn't re= ally get to work). I think having it on Firmware is reasonable, but I think having it on Vm wo= uld probably be better.