From: "Danilo Krummrich" <dakr@kernel.org>
To: "Ivan Tverdokhleb" <mbkchelofficialdev@gmail.com>
Cc: rust-for-linux@vger.kernel.org,
"Alice Ryhl" <aliceryhl@google.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Arun Pravin" <arunpravin.paneerselvam@amd.com>,
"Joel Fernandes" <jfern@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Onur Özkan" <work@onurozkan.dev>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] rust: gpu: buddy: store the allocator inside the Mutex
Date: Sat, 21 Nov 2026 16:28:35 +0100 [thread overview]
Message-ID: <DN0ZUECUCER4.QK2US2HOR3I4@kernel.org> (raw)
In-Reply-To: <20261119111850.33270-1-mbkchelofficialdev@gmail.com>
On Thu Nov 19, 2026 at 12:18 PM CET, Ivan Tverdokhleb wrote:
> @@ -313,16 +313,11 @@ pub struct GpuBuddyParams {
> ///
> /// # Invariants
> ///
> -/// The inner [`Opaque`] contains an initialized buddy allocator.
> +/// The `lock` field contains an initialized buddy allocator wrapped in `Opaque`.
> #[pin_data(PinnedDrop)]
> struct GpuBuddyInner {
> #[pin]
> - inner: Opaque<bindings::gpu_buddy>,
> -
> - // TODO: Replace `Mutex<()>` with `Mutex<Opaque<..>>` once `Mutex::new()`
> - // accepts `impl PinInit<T>`.
> - #[pin]
> - lock: Mutex<()>,
> + lock: Mutex<Opaque<bindings::gpu_buddy>>,
I think we should keep the name inner.
prev parent reply other threads:[~2026-11-21 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 11:18 [PATCH v2] rust: gpu: buddy: store the allocator inside the Mutex Ivan Tverdokhleb
2026-11-21 15:03 ` Joel Fernandes
2026-11-21 15:28 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DN0ZUECUCER4.QK2US2HOR3I4@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=arunpravin.paneerselvam@amd.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jfern@kernel.org \
--cc=lossin@kernel.org \
--cc=matthew.auld@intel.com \
--cc=mbkchelofficialdev@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox