From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D059F1A316E; Mon, 7 Jul 2025 16:19:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751905185; cv=pass; b=PoVpB3Z7L2DeLQQKCFyJgjmRSsW4bnsez3Y/yz9cggKfpXOZzrL+8waxlDiKkkIg8+Qb5ayx8bEBs1HsHiawTJNsIROmVH008NxGpfnI1gU78C76WpDWtiglZqNEcNAjOUELXDWOIj1Lr58DtIVRyovgR5qqJVkwYr+RFL3toxo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751905185; c=relaxed/simple; bh=R94avkSZjApSXUNZ0YQ4lxwJ6hTJ8++8l+29QNsZDtY=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=WAUBVDIDlYfVO2Yh+y/j/lsLZNbUk9tmrG1OqIk8CxeJrW7ZV7/Tkq1RPgrL6ZDKfM4AIJk70+ryHPOXWRAi+nLEe4yp6bGoPnPAH/O5/JRXF1GEvmBiBLYGPezK+Yk4TRDiuzIe6KjpvcVrVUWiJ8BMeFhXadbQeP2h2wuxS3E= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=jbsbNS7T; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="jbsbNS7T" ARC-Seal: i=1; a=rsa-sha256; t=1751905144; cv=none; d=zohomail.com; s=zohoarc; b=HZgmv52LJzlDRI+1GRTwzz6PMhGLJhuRxzJpb0yIdCcPaih8VQ3fweQAXXeOFXzrC2XxvJJBUnTTg49My+drZ0MC8F5uFODrxzexW74seKuoJHRMhGVyr4CXm3QHQarPU4XyfVQqtZF9/X9015gWaWkr2zv29XvBV7HatTjeE+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751905144; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ETLYFfIfOLg2rNaiX6F+ay4E3ts9u33x29yYCRsWi/Q=; b=QV0n3xPTo4wpnOHZ8/GpbIWmsodmAMsxpnU+Hg4C925qOyQ4s0q0sYnMRlgFrkUUYFRfW5xIdINqrWltAexi+EN6j79x8r+weRtLDw29Fgw5AgcTgeWW3cydX5kbUkuyAX96EFtnXiek7ELv8vRmk+4ejOFosh7z7x0eK9Jb8co= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1751905144; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:References:To:To:Reply-To; bh=ETLYFfIfOLg2rNaiX6F+ay4E3ts9u33x29yYCRsWi/Q=; b=jbsbNS7T+VebJkTLbe5JY2EU29NdGsT8DyGAXgge+jagX2BQD4mR1vRX/+60vchh Oaj3A2+WGZlyPwQWZdBPUfJo6fwKORY9EPpOBKVKD10jmuUle8ai+5z7axDm9/WoSKY QK2D2yBxPe6mWcAu6Ev1x/TtGn3tCpaA0TmjLt7c= Received: by mx.zohomail.com with SMTPS id 1751905142619899.7142083393121; Mon, 7 Jul 2025 09:19:02 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: [PATCH v6 3/6] rust: irq: add support for non-threaded IRQs and handlers From: Daniel Almeida In-Reply-To: Date: Mon, 7 Jul 2025 13:18:45 -0300 Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Thomas Gleixner , Benno Lossin , Bjorn Helgaas , =?utf-8?Q?Krzysztof_Wilczy=C5=84ski?= , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20250703-topics-tyr-request_irq-v6-0-74103bdc7c52@collabora.com> <20250703-topics-tyr-request_irq-v6-3-74103bdc7c52@collabora.com> To: Alice Ryhl X-Mailer: Apple Mail (2.3826.600.51.1.1) X-ZohoMailClient: External Alice, [=E2=80=A6] >> +/// The value that can be returned from an IrqHandler or a = ThreadedIrqHandler. >> +pub enum IrqReturn { >> + /// The interrupt was not from this device or was not handled. >> + None, >> + >> + /// The interrupt was handled by this device. >> + Handled, >> +} >> + >> +impl IrqReturn { >> + fn into_inner(self) -> u32 { >> + match self { >> + IrqReturn::None =3D> bindings::irqreturn_IRQ_NONE, >> + IrqReturn::Handled =3D> bindings::irqreturn_IRQ_HANDLED, >=20 > One option is to specify these in the enum: >=20 > /// The value that can be returned from an IrqHandler or a = ThreadedIrqHandler. > pub enum IrqReturn { > /// The interrupt was not from this device or was not handled. > None =3D bindings::irqreturn_IRQ_NONE, >=20 > /// The interrupt was handled by this device. > Handled =3D bindings::irqreturn_IRQ_HANDLED, > } This requires explicitly setting #[repr(u32)], which is something that = was reverted at an earlier iteration of the series on Benno=E2=80=99s = request. =E2=80=94 Daniel=