From: jens.korinth@tuta.io
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Rust For Linux" <rust-for-linux@vger.kernel.org>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Dirk Behme" <dirk.behme@gmail.com>
Subject: Re: [PATCH v3 1/3] rust: print: Add do_once_lite macro
Date: Mon, 11 Nov 2024 14:34:18 +0100 (CET) [thread overview]
Message-ID: <OBQQehb--B-9@tuta.io> (raw)
In-Reply-To: <CAH5fLggOJ1QMdzS=hp+wEGDSKEMFuCh=VPSga5jRy=F+knKE=Q@mail.gmail.com>
> One advantage of using a Once type is that we can use
> core::sync::atomic until we have working LKMM atomics and then we just
> swap out the Once type without having to modify the warn_once
> abstractions.
>
Ok, that's a really good argument. I'm a bit perplexed why the generic
`Atomic` type has such requirements, they seem unrelated to the semantics
of the interface. But since it is defined that way, `Once`, or `OnceLock` etc.,
seem the way to go.
Question is: Would you still merge the pr_*_once macros with the`do_once_lite` hidden in `print.rs` for now? Or would you rather wait until
the `Once` abstraction is available?
Jens
next prev parent reply other threads:[~2024-11-11 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 20:30 [PATCH v3 0/3] rust: Add pr_*_once macros Jens Korinth via B4 Relay
2024-11-09 20:30 ` [PATCH v3 1/3] rust: print: Add do_once_lite macro Jens Korinth via B4 Relay
2024-11-09 20:41 ` Miguel Ojeda
2024-11-09 21:33 ` jens.korinth
2024-11-09 21:44 ` Miguel Ojeda
2024-11-09 22:56 ` Boqun Feng
2024-11-10 7:45 ` jens.korinth
2024-11-10 19:23 ` Boqun Feng
2024-11-11 9:17 ` Alice Ryhl
2024-11-11 13:34 ` jens.korinth [this message]
2024-11-11 13:53 ` Alice Ryhl
2024-11-11 17:46 ` Boqun Feng
2024-11-09 20:30 ` [PATCH v3 2/3] rust: print: Add pr_*_once macros Jens Korinth via B4 Relay
2024-11-09 20:30 ` [PATCH v3 3/3] rust: error: Replace pr_warn by pr_warn_once Jens Korinth via B4 Relay
2024-11-11 7:05 ` [PATCH v3 0/3] rust: Add pr_*_once macros Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OBQQehb--B-9@tuta.io \
--to=jens.korinth@tuta.io \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dirk.behme@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).