From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.w14.tutanota.de (mail.w14.tutanota.de [185.205.69.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E45C14AD29; Wed, 27 Nov 2024 20:39:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.205.69.214 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732739944; cv=none; b=F1R56WVFvLzL4ucczJtVrTYOkNMfyBW3hr5sXL7Im0a5n1zChyA0qpr1slFzob3yLamKqw4rZ+9BDyoNewuwbmRr/k4yo7xJ2Hn0HxdNk9V9qgIqLYhaaziuUf51ojBCMLeNQbopsZNavc/3FM8sGZ414AfRSL1WuqbID80C0WI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732739944; c=relaxed/simple; bh=s27P/8glGyqvC9Z46lGh13QRNKPymyQXSPRZd0cgBlA=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=at8xZE2lBt9jWPASTjrlg4ootOpAgJw5O8Wmbzp+uVDGzusTjd1AtjECpLwppWJjyRxjvkwBUKiVD4U/ecud94lwNDFJ6SZiP8VaULR5yL32uK75e2SBc/Snw4uRpIL+VmyNIwZDqOPPiOYAFjW7X6on6XEoq8y2CZ7KugBgj/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuta.io; spf=pass smtp.mailfrom=tuta.io; dkim=pass (2048-bit key) header.d=tuta.io header.i=@tuta.io header.b=etCSLXZV; arc=none smtp.client-ip=185.205.69.214 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tuta.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuta.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuta.io header.i=@tuta.io header.b="etCSLXZV" Received: from tutadb.w10.tutanota.de (w10.api.tuta.com [IPv6:fd:ac::d:10]) by mail.w14.tutanota.de (Postfix) with ESMTP id A5E393F52D54; Wed, 27 Nov 2024 21:39:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1732739940; s=s1; d=tuta.io; h=From:From:To:To:Subject:Subject:Content-Description:Content-ID:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Cc:Cc:Date:Date:In-Reply-To:In-Reply-To:MIME-Version:MIME-Version:Message-ID:Message-ID:Reply-To:References:References:Sender; bh=s27P/8glGyqvC9Z46lGh13QRNKPymyQXSPRZd0cgBlA=; b=etCSLXZVOBd/q3FoE7sfOE7Hnedy3fNLzNVUWau6a6nZ+9oX6oRiC+R/xY8qRpcc IEQLojdm0l4UMzEze8sSI9hggbVkMrCFT6ge4n4wtfr0a6j8m6uHRMWS3GGtUj8cUqn UVaabHR5jpbTfhT7V2oJn9yk0mIzvy/Cbd2I8P5TyXL6djX9yjoYwM5FS6Lf6cazOdj 6opWYej5A4wKUpRUR43k/z7Awsc0DO0S34FW6/OTxJmJzBx1usmKVIuo6vAwzfgfdvA E15MXtLHiNtl/tZLCz5/juhx8LYcsyS9YIJ8uqL8DbUBa6iq2RqaG7wkm5495KVcXpr iyyfj2GnuQ== Date: Wed, 27 Nov 2024 21:39:00 +0100 (CET) From: jens.korinth@tuta.io To: Miguel Ojeda Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Rust For Linux , FUJITA Tomonori , Dirk Behme , Linux Kernel Message-ID: In-Reply-To: References: <20241126-pr_once_macros-v4-0-410b8ca9643e@tuta.io> <20241126-pr_once_macros-v4-3-410b8ca9643e@tuta.io> Subject: Re: [PATCH v4 3/3] rust: error: Replace pr_warn by pr_warn_once Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > I would mention here the merits between `pr_warn_once` vs. `WARN_ONCE` > and why the former was picked in this patch (especially since the > `TODO` suggests the latter). Tbh, I am not 100% whether this should be here at all. The bug is not here, it's at the call site. It should probably be a `try_from` instead, to raise the error there? Jens