From: Greg KH <gregkh@linuxfoundation.org>
To: Finn Behrens <fin@nyantec.com>
Cc: rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Rust PROC FILESYSTEM abstractions
Date: Sat, 7 Jan 2023 12:02:14 +0100 [thread overview]
Message-ID: <Y7lRNocrUCB7xQXE@kroah.com> (raw)
In-Reply-To: <61BCB8A9-044D-4321-AF3F-1387FCDB230E@nyantec.com>
On Sat, Jan 07, 2023 at 11:44:51AM +0100, Finn Behrens wrote:
>
>
> On 7 Jan 2023, at 11:43, Greg KH wrote:
>
> > On Sat, Jan 07, 2023 at 11:36:27AM +0100, Finn Behrens wrote:
> >> Hi,
> >>
> >> I’v started to implement the proc filesystem abstractions in rust, as
> >> I want to use it for a driver written in rust. Currently this requires
> >> some rust code that is only in the rust branch, so does not apply onto
> >> 6.2-rc2.
> >
> > Please no, no new driver should ever be using /proc at all. Please
> > stick with the sysfs api which is what a driver should always be using
> > instead.
>
> Oh did not know that, only translated a C driver from my work to rust,
> and there procfs was used. But okay, will change it to sysfs.
Please do, and please work to get your driver upstream, odds are if this
type of issue is present in it, it could use a good review from others.
thanks,
greg k-h
prev parent reply other threads:[~2023-01-07 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 10:36 Rust PROC FILESYSTEM abstractions Finn Behrens
2023-01-07 10:43 ` Greg KH
2023-01-07 10:44 ` Finn Behrens
2023-01-07 11:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7lRNocrUCB7xQXE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fin@nyantec.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).