From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545D0C54EE9 for ; Tue, 27 Sep 2022 14:56:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232445AbiI0O4s (ORCPT ); Tue, 27 Sep 2022 10:56:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232514AbiI0O4T (ORCPT ); Tue, 27 Sep 2022 10:56:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA7EF979E8; Tue, 27 Sep 2022 07:55:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 566E2619E8; Tue, 27 Sep 2022 14:55:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 437E1C433C1; Tue, 27 Sep 2022 14:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664290524; bh=aUKfoGvdKDzMOXhk0hJy8k35gYHkpZkep32NjUanwCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A7t/c8uRme2jhzpK8riOPTNuNrQffCT9WLogKMaylDVTcRw2uwaNe2z7raw11OAbW d3NDCbdprubws4K+N2rONj6jjzvYjhi8c8B27jSsQz9r/eUpn7RZ5jIfMEO2Vm6lbh rFY/zJNfsPkN8mTEMjabMqTyDAH8m3a+U5iZolPU= Date: Tue, 27 Sep 2022 16:55:22 +0200 From: Greg Kroah-Hartman To: Miguel Ojeda Cc: Linus Torvalds , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, patches@lists.linux.dev, Jarkko Sakkinen , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Boqun Feng , Matthew Wilcox Subject: Re: [PATCH v10 04/27] kallsyms: support "big" kernel symbols Message-ID: References: <20220927131518.30000-1-ojeda@kernel.org> <20220927131518.30000-5-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220927131518.30000-5-ojeda@kernel.org> Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On Tue, Sep 27, 2022 at 03:14:35PM +0200, Miguel Ojeda wrote: > Rust symbols can become quite long due to namespacing introduced > by modules, types, traits, generics, etc. > > Increasing to 255 is not enough in some cases, therefore > introduce longer lengths to the symbol table. > > In order to avoid increasing all lengths to 2 bytes (since most > of them are small, including many Rust ones), use ULEB128 to > keep smaller symbols in 1 byte, with the rest in 2 bytes. > > Reviewed-by: Kees Cook > Co-developed-by: Alex Gaynor > Signed-off-by: Alex Gaynor > Co-developed-by: Wedson Almeida Filho > Signed-off-by: Wedson Almeida Filho > Co-developed-by: Gary Guo > Signed-off-by: Gary Guo > Co-developed-by: Boqun Feng > Signed-off-by: Boqun Feng > Co-developed-by: Matthew Wilcox > Signed-off-by: Matthew Wilcox > Signed-off-by: Miguel Ojeda > --- > kernel/kallsyms.c | 26 ++++++++++++++++++++++---- > scripts/kallsyms.c | 29 ++++++++++++++++++++++++++--- > 2 files changed, 48 insertions(+), 7 deletions(-) Reviewed-by: Greg Kroah-Hartman