From: Oliver Mangold <oliver.mangold@pm.me>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Asahi Lina" <lina@asahilina.net>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/4] rust: rename AlwaysRefCounted to RefCounted
Date: Mon, 24 Mar 2025 07:32:08 +0000 [thread overview]
Message-ID: <Z-EKcUppzh-5oTI6@mango> (raw)
In-Reply-To: <67dd91ca.050a0220.acaf0.79d2@mx.google.com>
On 250321 0920, Boqun Feng wrote:
> On Thu, Mar 13, 2025 at 07:00:11AM +0000, Oliver Mangold wrote:
> > AlwaysRefCounted will become a marker trait to indicate that it is allowed
> > to obtain an ARef from a `&`, which cannot be allowed for types which are
> > also Ownable.
> >
>
> This commit log doesn't explain why we need to do this.
Hi Boqun,
what exactly do you have in mind? It mentions that it is to allow types that
are both Ownable and RefCounted. That the next step is to introduce
OwnableRefCounted? That we want to safely convert from ARef to Owned?
> > +
> > +// SAFETY: we currently do not implement `Ownable`, thus it is okay to can obtain an `ARef<Request>`
>
> s/we/We
>
Missed that one. Thanks.
Best regards,
Oliver
next prev parent reply other threads:[~2025-03-24 7:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <GwULoA3hxsCsNdxJ4lw7WqNC5bhCMacx5xMre9hZV2GWDdYmQx9rYVzHadna4KGiko3Glypv-AeXUsoECQB-EA==@protonmail.internalid>
2025-03-13 6:59 ` [PATCH v8 0/4] New trait OwnableRefCounted for ARef<->Owned conversion Oliver Mangold
2025-03-13 7:00 ` [PATCH v8 1/4] rust: types: Add Ownable/Owned types Oliver Mangold
2025-03-21 16:08 ` Boqun Feng
2025-03-25 12:00 ` Oliver Mangold
2025-03-23 20:46 ` Andreas Hindborg
2025-03-13 7:00 ` [PATCH v8 2/4] rust: rename AlwaysRefCounted to RefCounted Oliver Mangold
2025-03-21 16:20 ` Boqun Feng
2025-03-24 7:32 ` Oliver Mangold [this message]
2025-03-13 7:00 ` [PATCH v8 3/4] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol Oliver Mangold
2025-03-13 7:00 ` [PATCH v8 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
2025-03-21 16:37 ` Boqun Feng
2025-03-24 7:59 ` Oliver Mangold
2025-03-23 20:19 ` [PATCH v8 0/4] New trait OwnableRefCounted for ARef<->Owned conversion Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-EKcUppzh-5oTI6@mango \
--to=oliver.mangold@pm.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).