Re: [PATCH v3 1/5] rust: miscdevice: Provide accessor to pull out miscdevice::this_device

Lee Jones
2024-12-06T12:06:15Z

On Fri, 06 Dec 2024, Miguel Ojeda wrote:

> On Fri, Dec 6, 2024 at 10:05 AM Lee Jones <lee@kernel.org> wrote:
> >
> > + /// Returns a pointer to the current Device
>
> Nit: please use intra-doc links wherever possible (if not possible,
> please at least format type names as code). We also end sentences with
> periods in docs and comments. So e.g.:
>
> /// Returns a pointer to the current [`Device`].
>
> There was a comment about this line in the previous version, v3, but
> there does not seem to be a change. But then again, the title of this
> patch is v3 and not v4 -- not sure what happened here.

This patch should no longer be part of the set after v3.

Looks like v3 was still in the output folder so was sent again with v4
by mistake. My tooling usually strips out old versions, so I'm not sure
what went wrong specifically.

Thanks for the comment style tips. I'll make the changes.

--
Lee Jones [李琼斯]