Re: [PATCH v3 3/5] samples: rust: Provide example using the new Rust MiscDevice abstraction

Lee Jones
2024-12-06T07:51:50Z

On Fri, 06 Dec 2024, Greg KH wrote:

> On Fri, Dec 06, 2024 at 07:35:58AM +0000, Lee Jones wrote:
> > On Fri, 06 Dec 2024, Greg KH wrote:
> >
> > > On Fri, Dec 06, 2024 at 07:14:30AM +0000, Lee Jones wrote:
> > > > On Fri, 06 Dec 2024, Greg KH wrote:
> > > > > > + fn open() -> Result<KBox<Self>> {
> > > > > > + pr_info!("Opening Rust Misc Device Sample\n");
> > > > >
> > > > > I'd prefer this to be dev_info() to start with please.
> > > >
> > > > This is not possible at the moment. Please see the cover-letter.
> > >
> > > Then why make the change to miscdevice.rs if that pointer provided there
> > > doesn't work for you here?
> >
> > It's half the puzzle to get it working. We're waiting on the other
> > (more complex) part from Alice before we can make use of it. Would you
> > like me to remove it from the set until we have all of the pieces?
>
> I'm confused, if you have the reference here, what is preventing it from
> being used?
>
> And yes, if it doesn't work, it shouldn't be part of this series :)

It works - we can use dev_*() in .init, but not after (i.e. in open(),
ioctl(), etc).

I'll pull it from the series and let Alice re-post it when we have all
of the parts.

--
Lee Jones [李琼斯]