Re: [PATCH v5] rust: sync: add #[must_use] to Lock::try_lock

Miguel Ojeda
2024-12-12T11:25:24Z

On Thu, Dec 12, 2024 at 4:11 AM Jason Devers <dev.json2@gmail.com> wrote:
>
> + // Note that `T` is `#[must_use]` but `Option<T>` is not.

I think the wording of the comment was not updated? If there is a
reason for not doing it, then you should normally put it in the
changelog (i.e. after the first `---` line) or you would reply to the
original feedback with the reason.

Thanks!

Cheers,
Miguel