From: Danilo Krummrich <dakr@kernel.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Gary Guo" <gary@garyguo.net>, "Miguel Ojeda" <ojeda@kernel.org>,
"DJ Delorie" <dj@redhat.com>, "Eric Blake" <eblake@redhat.com>,
"Paul Eggert" <eggert@cs.ucla.edu>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-man@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] rust: alloc: satisfy POSIX alignment requirement
Date: Wed, 12 Feb 2025 21:58:23 +0100 [thread overview]
Message-ID: <Z60Lb4OK3jLCAAra@pollux> (raw)
In-Reply-To: <CAJ-ks9=-ZQpmhJRs3YstZBGb9UvLwRQJ7od+dsc_sYZtwUhF2A@mail.gmail.com>
On Wed, Feb 12, 2025 at 03:47:11PM -0500, Tamir Duberstein wrote:
> Looks like I wasn't the only one to fall into the trap (rust/kernel/io.rs):
>
> #[inline]
> const fn io_addr_assert<U>(&self, offset: usize) -> usize {
> build_assert!(Self::offset_valid::<U>(offset, SIZE));
>
> self.addr() + offset
> }
>
> since offset isn't known at compile time, this can easily be misused?
Well, that's intentional.
iomem.readb(0x0) // succeeds if SIZE >=1
iomem.readb(foo) // fails if foo is not known at compile time
iomem.try_readb(foo) // succeeds if self.maxsize() >= 1
next prev parent reply other threads:[~2025-02-12 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 14:43 [PATCH v5] rust: alloc: satisfy POSIX alignment requirement Tamir Duberstein
2025-02-12 15:40 ` Danilo Krummrich
2025-02-12 15:42 ` Tamir Duberstein
2025-02-12 16:38 ` Gary Guo
2025-02-12 17:01 ` Danilo Krummrich
2025-02-12 18:44 ` Tamir Duberstein
2025-02-12 20:01 ` Danilo Krummrich
2025-02-12 20:47 ` Tamir Duberstein
2025-02-12 20:58 ` Danilo Krummrich [this message]
2025-02-12 21:24 ` Tamir Duberstein
2025-02-13 1:00 ` Tamir Duberstein
2025-02-13 11:21 ` Gary Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z60Lb4OK3jLCAAra@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dj@redhat.com \
--cc=eblake@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).