From: Danilo Krummrich <dakr@kernel.org>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: airlied@gmail.com, simona@ffwll.ch, corbet@lwn.net,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, ajanulgu@redhat.com, lyude@redhat.com,
pstanner@redhat.com, zhiw@nvidia.com, cjia@nvidia.com,
jhubbard@nvidia.com, bskeggs@nvidia.com, acurrid@nvidia.com,
ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
rust-for-linux@vger.kernel.org, joelagnelf@nvidia.com
Subject: Re: [PATCH 1/2] gpu: nova-core: add initial driver stub
Date: Tue, 4 Feb 2025 19:46:23 +0100 [thread overview]
Message-ID: <Z6Jgf-cVt_AlM6Qd@cassiopeiae> (raw)
In-Reply-To: <20250203202410.GA3936980@joelbox2>
On Mon, Feb 03, 2025 at 03:24:10PM -0500, Joel Fernandes wrote:
> Hi Danilo,
>
> On Fri, Jan 31, 2025 at 11:04:24PM +0100, Danilo Krummrich wrote:
> > +#[pin_data]
> > +pub(crate) struct NovaCore {
> > + #[pin]
> > + pub(crate) gpu: Gpu,
> > +}
>
> I am curious what is the need for pinning here in the patch in its current
> form, is it for future-proofing?
Yes, it is.
It's not always needed, but since I know that further down the road we'll need
at least a few mutexes, it seemed reasonable to already consider it.
>
> I looked through the sample PCI driver example you had posted and did not see
> pinning there [1]. Thanks for the clarification.
> [1] https://lore.kernel.org/all/20241219170425.12036-12-dakr@kernel.org/
next prev parent reply other threads:[~2025-02-04 18:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 22:04 [PATCH 1/2] gpu: nova-core: add initial driver stub Danilo Krummrich
2025-01-31 22:04 ` [PATCH 2/2] gpu: nova-core: add initial documentation Danilo Krummrich
2025-02-04 18:40 ` Timur Tabi
2025-02-04 18:56 ` Danilo Krummrich
2025-02-01 4:01 ` [PATCH 1/2] gpu: nova-core: add initial driver stub John Hubbard
2025-02-01 13:52 ` Danilo Krummrich
2025-02-01 19:43 ` John Hubbard
2025-02-01 8:14 ` Karol Herbst
2025-02-01 8:16 ` Karol Herbst
2025-02-01 12:08 ` Danilo Krummrich
2025-02-01 8:33 ` Greg KH
2025-02-01 12:12 ` Danilo Krummrich
2025-02-01 15:31 ` Greg KH
2025-02-03 20:24 ` Joel Fernandes
2025-02-03 20:59 ` John Hubbard
2025-02-03 21:53 ` Joel Fernandes
2025-02-04 18:46 ` Danilo Krummrich [this message]
2025-02-04 21:09 ` Joel Fernandes
2025-02-04 18:42 ` Timur Tabi
2025-02-04 18:56 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6Jgf-cVt_AlM6Qd@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acurrid@nvidia.com \
--cc=airlied@gmail.com \
--cc=ajanulgu@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bskeggs@nvidia.com \
--cc=cjia@nvidia.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joel@joelfernandes.org \
--cc=joelagnelf@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=pstanner@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).