From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC1F214209; Thu, 6 Feb 2025 11:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738842554; cv=none; b=hsWLuGd3/bQoFTRB4/y2nvH+p+6BkOz/6hdb/FU1kfAPjXLJsRLUWLhs9zgrFo0TaT2LbLMGdViT2KvHvbTzkELvCBUjuU2GpYU2hRtDLMG7QO6ACBfWgnMZDzq3CulhI9GEfDaMRz4rJjCdIRmO9g6mgaX1pO3FjRHGb4Whgb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738842554; c=relaxed/simple; bh=KSJZYha5ODw9MEGcXjXaZ3dmdhOL5dml3qTU7QSfRB8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WEitoi3qAYZVJ61PCKb6MrhIzb5HXi3YcHPUlgLc0q5ilKZJuEVJYfrQEcxzzJRorMuq8MVjZLE2h52teQlGNDVUo+/4sAaMGVvbZTLZF7/561g5TPEQ7m+fDfMbhcKVNr+1MzxXWgazAtpE6CYzTUXr3ROQGGzSPOwdyhAhfC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t0/FKuo6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t0/FKuo6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C32EC4CEDD; Thu, 6 Feb 2025 11:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738842554; bh=KSJZYha5ODw9MEGcXjXaZ3dmdhOL5dml3qTU7QSfRB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0/FKuo6jcdQia+NSMwPtFRzVUMvP17mhCYkMWpV9H38ZuWIwJTIvIAp4VqNvm+N9 JY90Osk53bZN6R5W7IESzs3C2mtCDt7H6BE1uburk3QI7zbN7s8Tg8XYLTO6g2gl5T yNeaEFFrR5v/FRtMYmU9zr5uSZUqHo/uH3aGskDilchl/rVfxDfOpCV6flgTwW4YgH HjS9Taz9AiKhaTEnjbX+siWpwJTCsyLAWxkwDjDU3kR6fkyo4KprmpvxdnZkhFMESf 1vPQOMg88ceBRjg6wDxjYpCPUWY/LugTkp0PlFlijlQvX9ePy54fwBhJg0jux3jQey PAEQPvthHf6dQ== Date: Thu, 6 Feb 2025 12:49:06 +0100 From: Danilo Krummrich To: Viresh Kumar Cc: "Rafael J. Wysocki" , Miguel Ojeda , Danilo Krummrich , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Michael Turquette , Stephen Boyd , linux-pm@vger.kernel.org, Vincent Guittot , Nishanth Menon , rust-for-linux@vger.kernel.org, Manos Pitsidianakis , Erik Schilling , Alex =?iso-8859-1?Q?Benn=E9e?= , Joakim Bech , Rob Herring , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH V8 06/14] rust: Add bare minimal bindings for clk framework Message-ID: References: Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 06, 2025 at 02:58:27PM +0530, Viresh Kumar wrote: > This adds very basic bindings for the clk framework, implements only > clk_get() and clk_put(). These are the bare minimum bindings required > for many users and are simple enough to add in the first attempt. > > These will be used by Rust based cpufreq / OPP core to begin with. > > Signed-off-by: Viresh Kumar > --- > MAINTAINERS | 1 + > rust/bindings/bindings_helper.h | 1 + > rust/kernel/clk.rs | 48 +++++++++++++++++++++++++++++++++ > rust/kernel/lib.rs | 2 ++ > 4 files changed, 52 insertions(+) > create mode 100644 rust/kernel/clk.rs > > diff --git a/MAINTAINERS b/MAINTAINERS > index ff4511914e0a..604717065476 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5780,6 +5780,7 @@ F: include/dt-bindings/clock/ > F: include/linux/clk-pr* > F: include/linux/clk/ > F: include/linux/of_clk.h > +F: rust/kernel/clk.rs > X: drivers/clk/clkdev.c > > COMMON INTERNET FILE SYSTEM CLIENT (CIFS and SMB3) > diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h > index 59b4bc49d039..4eadcf645df0 100644 > --- a/rust/bindings/bindings_helper.h > +++ b/rust/bindings/bindings_helper.h > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs > new file mode 100644 > index 000000000000..123cdb43b115 > --- /dev/null > +++ b/rust/kernel/clk.rs > @@ -0,0 +1,48 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +//! Clock abstractions. > +//! > +//! C header: [`include/linux/clk.h`](srctree/include/linux/clk.h) > + > +use crate::{ > + bindings, > + device::Device, > + error::{from_err_ptr, Result}, > + prelude::*, > +}; > + > +use core::ptr; > + > +/// A simple implementation of `struct clk` from the C code. > +#[repr(transparent)] > +pub struct Clk(*mut bindings::clk); Guess this should be Opaque. > + > +impl Clk { > + /// Creates `Clk` instance for a device and a connection id. > + pub fn new(dev: &Device, name: Option<&CStr>) -> Result { > + let con_id = if let Some(name) = name { > + name.as_ptr() as *const _ > + } else { > + ptr::null() > + }; > + > + // SAFETY: It is safe to call `clk_get()`, on a device pointer earlier received from the C > + // code. > + Ok(Self(from_err_ptr(unsafe { > + bindings::clk_get(dev.as_raw(), con_id) > + })?)) > + } > + > + /// Obtain the raw `struct clk *`. > + pub fn as_raw(&self) -> *mut bindings::clk { > + self.0 > + } > +} > + > +impl Drop for Clk { > + fn drop(&mut self) { > + // SAFETY: By the type invariants, we know that `self` owns a reference, so it is safe to > + // relinquish it now. > + unsafe { bindings::clk_put(self.0) }; > + } > +} > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs > index ccbf7fa087a0..77d3b1f82154 100644 > --- a/rust/kernel/lib.rs > +++ b/rust/kernel/lib.rs > @@ -40,6 +40,8 @@ > pub mod block; > #[doc(hidden)] > pub mod build_assert; > +#[cfg(CONFIG_COMMON_CLK)] > +pub mod clk; > pub mod cpu; > pub mod cpumask; > pub mod cred; > -- > 2.31.1.272.g89b43f80a514 > >