rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boqun Feng <boqun.feng@gmail.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>,
	"Hamza Mahfooz" <hamzamahfooz@linux.microsoft.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Lai Jiangshan" <jiangshanlai@gmail.com>,
	rust-for-linux@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Wedson Almeida Filho" <walmeida@microsoft.com>,
	"Nell Shamrell-Harrington" <nells@linux.microsoft.com>,
	"Dirk Behme" <dirk.behme@gmail.com>,
	"Konstantin Andrikopoulos" <kernel@mandragore.io>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Roland Xu" <mu001999@outlook.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: workqueue: define built-in bh queues
Date: Fri, 21 Feb 2025 20:41:29 -0800	[thread overview]
Message-ID: <Z7lVeWFX-8uQJaJC@Mac.home> (raw)
In-Reply-To: <Z7lUcq3PycSSHiXx@kernel.org>

On Sat, Feb 22, 2025 at 06:37:06AM +0200, Jarkko Sakkinen wrote:
> On Sat, Feb 22, 2025 at 06:17:41AM +0200, Jarkko Sakkinen wrote:
> > On Fri, Feb 21, 2025 at 11:45:38PM +0100, Miguel Ojeda wrote:
> > > On Fri, Feb 21, 2025 at 11:36 PM Hamza Mahfooz
> > > <hamzamahfooz@linux.microsoft.com> wrote:
> > > >
> > > > We provide these methods because it lets us access these queues from
> > > > Rust without using unsafe code.
> > > >
> > > > Signed-off-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>
> > > 
> > > Cc'ing WORKQUEUE -- thanks!
> > 
> > Not meaning to complain but it by practical has no commit message.
> 
> oops, sorry, "... but by practical means it ..."
> 
> Anyway I hope my message was received ;-) Leaves me wonder tho why
> this was queued because it apparently is not even part of a patch

What do you mean by "queued"? IIUC, Miguel was just copying workqueue
maintainers, since they should be in the review process.

Thanks for your review in another email anyway!

Regards,
Boqun

> set. "zero callers" should never be merged to mainline...
> 
> If however such patch is merged, the commit message should probably
> address this exceptional condition.
> 
> R, Jarkko

  reply	other threads:[~2025-02-22  4:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 22:35 [PATCH] rust: workqueue: define built-in bh queues Hamza Mahfooz
2025-02-21 22:45 ` Miguel Ojeda
2025-02-22  4:17   ` Jarkko Sakkinen
2025-02-22  4:37     ` Jarkko Sakkinen
2025-02-22  4:41       ` Boqun Feng [this message]
2025-02-22  6:04         ` Jarkko Sakkinen
2025-02-22 11:57           ` Miguel Ojeda
2025-02-24 17:26             ` Tejun Heo
2025-02-22  4:15 ` Jarkko Sakkinen
2025-02-22 11:53   ` Miguel Ojeda
2025-02-24 17:19 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z7lVeWFX-8uQJaJC@Mac.home \
    --to=boqun.feng@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=dakr@kernel.org \
    --cc=dirk.behme@gmail.com \
    --cc=gary@garyguo.net \
    --cc=hamzamahfooz@linux.microsoft.com \
    --cc=jarkko@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel@mandragore.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mu001999@outlook.com \
    --cc=nells@linux.microsoft.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=walmeida@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).