From: Boqun Feng <boqun.feng@gmail.com>
To: Oliver Mangold <oliver.mangold@pm.me>
Cc: "Andreas Hindborg" <a.hindborg@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2] rust: adding UniqueRefCounted and UniqueRef types
Date: Fri, 28 Feb 2025 10:33:44 -0800 [thread overview]
Message-ID: <Z8IBiBi6CSRxfxiE@boqun-archlinux> (raw)
In-Reply-To: <I2EuahEO9YG75qdfIlsanLJ9iOfr0OlKJr6nw_cqOG0rVrZUEZGhdfENkLawNCpSqP8uSGMODCeEmsYv6clgYg==@protonmail.internalid>
On Fri, Feb 28, 2025 at 06:22:58PM +0000, Oliver Mangold wrote:
> On 250228 1009, Boqun Feng wrote:
> >
> > Please add the "# Examples" section as I requested:
> >
> > https://lore.kernel.org/rust-for-linux/Z8HcHVtPiG-X6ujP@Mac.home/
> >
> > I also would like to know why do you think it's OK to ignore my previous
> > comment, thanks!
> >
>
> I intend to. Don't worry. I totally have it in mind that, this is missing.
> As said, I will do it in a couple of days. Sorry if the update
> caused confusion.
>
I should appologize as well, after re-reading the email exchange between
us, I realized I wasn't clear about whether my request was including the
tests with the patch or not. So it's reasonable you thought a separate
patch would work.
Now as we cleared things, I want to make sure that it's clear that I
would like to see the patch with examples in it.
> I am aware this won't be the final version, but I thought
> I still post this one correctly formatted, as Miguel requested.
>
Yes, I figured that's what you planned to do, although it's better if
you could provide some information between versions, one example would
be:
https://lore.kernel.org/rust-for-linux/20250227193522.198344-1-lyude@redhat.com/
i.e. you can add some description after the "---" line, and that won't
affect git to apply the patches. Usually people put changes between
versions, and in this case since you just want to update a version that
is not the final version, you can add some description about that there
as well.
> I assure you, I'm not ignoring your comment and request at all.
>
Thanks! Again, sorry for not being clear in previous emails.
Regards,
Boqun
> Oliver
>
next prev parent reply other threads:[~2025-02-28 18:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 18:22 [PATCH v2] rust: adding UniqueRefCounted and UniqueRef types Oliver Mangold
2025-02-28 18:33 ` Boqun Feng [this message]
2025-02-28 19:01 ` Andreas Hindborg
2025-02-28 19:06 ` Boqun Feng
2025-02-28 19:16 ` Oliver Mangold
2025-02-28 19:25 ` Andreas Hindborg
2025-02-28 19:47 ` Oliver Mangold
2025-02-28 20:07 ` Oliver Mangold
-- strict thread matches above, loose matches on Subject: below --
2025-02-28 18:41 Oliver Mangold
2025-02-28 14:43 [PATCH] " Oliver Mangold
2025-02-28 18:01 ` [PATCH v2] " Oliver Mangold
2025-02-28 18:09 ` Boqun Feng
2025-02-28 18:16 ` Boqun Feng
2025-02-28 18:29 ` Andreas Hindborg
2025-03-03 14:09 ` Andreas Hindborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8IBiBi6CSRxfxiE@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=oliver.mangold@pm.me \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).