From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3A0D261597; Tue, 11 Mar 2025 17:24:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741713870; cv=none; b=qEhxudG2jRbqdgG9iWX+c5m2meOeUwYTJ9w4DRtM/2WxGNyKk6WvxLUsl9WD5IDAWrt2KT+s0LyWFDg1YfY+sZplFIQv0WXRmEbU65U4bVrlyaFKZVkDMaLRpERq3vromF6jrqYvz1gUnh4o7IgsVeujcgW0/1aVk4VXYXd8OHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741713870; c=relaxed/simple; bh=KIU1kDjFKCRa7RExYaAQyrL8Xgh8AnRVNSdFZztpDmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NcKRKPc3tpPV2e3OEkvCBb/Cw4HiU1YAJJsfg7kqFKqaCAqh8DivETMe7Qyy3fHTWtCHpwCKs9el0COndrQHehTCavQWj46q463JAa9NubsaXiVhzfYsAE1uWIbS8Go6IT7UKi+Pqi0HODsujfEdy6BRRHfstcDWJD0eYH/b5Do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MmM07lvd; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MmM07lvd" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39130ee05b0so3630018f8f.3; Tue, 11 Mar 2025 10:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741713867; x=1742318667; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Emc1Xs6Nt2lcLTt98R/fnZSfo2YWpjMGrC8QYEWTrwk=; b=MmM07lvdIFTRsMw4HtIfQ/pPCjmpW0VS29TByMwT58HFWiIXuL5GnP5jf8AT6cDU/q CJQiKo1UCMJDf5j4omKZlKrTZpZCGv3aPRt+OCT1vkXG8JmTMdBpQKN5Gs56o8waSFky Ek8ldrn2OzNmVwSi+sdDdyO3wuhlAdWxEQsNAnWJMMX4E1Jxwls3SaCvCd8PaA0ej1Ao x0Y77bRUCgTG8yPwf57KYlF3PyolOS3SvORlnthG4/WVMEhfE6+NvVh4hFlmKZYO1NWY sGqUSL/A3B0JMLrP25XJj7EfWVDecYy/iOrN3+ng1U8VcHSWrqbPEcVf0WyZCNu84NoQ pRfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741713867; x=1742318667; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Emc1Xs6Nt2lcLTt98R/fnZSfo2YWpjMGrC8QYEWTrwk=; b=nZYalOpwE2A+1P5BKtFohXEMFB77Kaz6BqW/nto1qsWwSvbKrcxC23MRbQijESafLN tkLqKjkOG91bsfr8pSQHNXFRman5r2OdKEJjoICka+aXPRbmLn0LFkBGgjGOb5+6cM6g MQyU9HQup2MFDN6Bl7KWPRn1qFGteqfw3+7rGEsBV3NTCgveUA+VafmIdd7yyR+Efn5T 4fOsaTvATyzJrORrNR4fAW43hlCIdR+/AyGQ4TY9J0XrqYlrGvZKuxa+CR3V1icJuQ2K 2dY1PmxzJ0N44eMTtAMaJ0zjJsCbZR/P1xQD+Jc0Ejt4/fA4inrrsCDhtzPC7mKDU3al 2C2Q== X-Forwarded-Encrypted: i=1; AJvYcCUbgHMyw8wYS8zYFvTJungJaJn7KtHvctsDmY9tykYboETOCZ8rfBaLJbSqL/xx3CA8rG/s+2Vf9OVFQlY=@vger.kernel.org, AJvYcCVPRiycfDr7k01VUSZ1RWsN/1M8Q0sNPx5+uAT7mD8gQQQ3tn+bvHmL1ujSuBd3ZTw9ErlV+uXzYQFPHoZ1wdI=@vger.kernel.org, AJvYcCXmeZK71xryFexs+GRjIiP/ivCQIAMgfavDavUEmWH+b+PlK3m5c33VGv8BTG9bUcoIgGHyhR6e8Bhv@vger.kernel.org X-Gm-Message-State: AOJu0YxFpzdedFh7Gnt7FBWscrLKNnnqwWfvy/MaDfwx01CmeMw56ajE C/fKhRq/DzbSA+nUUHnrUO6FmtpQcbpIS/98V4YSQm0/D8yrgFmc X-Gm-Gg: ASbGnct6w++os4y3CpIWFXgYb/BzmRhvP5gUYxjwOFyR+piM0jKH7nrStkDYH5d4v5c NCti1xPHq8Mmhf2VmPDEXUnkPz3jb/EncTitCdE7cQm29hiuWGaZU/U0KXOrFJkE16ZskiUw91R F2VJgIRhT1luEKVGydZD+p91xvjWASZBqqMPAZPayekLYmA4zyIRPQmwpTIub2X8c0smoD8vIK4 GomQGa2s0aBslmjPkC/M7VfgeUZ0x1MvZNiYfPmK54J3dQDlmR8QKajtcZYhY6p/0hmOGELz/z7 CrnEM8K45sjqQ0t3jK4u0gzPUItIw96jaswGQrvphQ== X-Google-Smtp-Source: AGHT+IFQ2HvYUYPl8jM+ap0Z7CyEC5tGiqW8dRE2rUcBcsI7NwGDKJKhcwZafBXXqQlRNN+CtuIS4g== X-Received: by 2002:a05:6000:1862:b0:390:fe4b:70b9 with SMTP id ffacd0b85a97d-39132d6c5demr20101806f8f.21.1741713866884; Tue, 11 Mar 2025 10:24:26 -0700 (PDT) Received: from fedora ([94.73.34.53]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c0195casm19077229f8f.53.2025.03.11.10.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 10:24:26 -0700 (PDT) Date: Tue, 11 Mar 2025 18:24:23 +0100 From: =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= To: gregkh@linuxfoundation.org Cc: Jonathan.Cameron@huawei.com, airlied@gmail.com, aleksander.lobakin@intel.com, andriy.shevchenko@linux.intel.com, bhelgaas@google.com, broonie@kernel.org, dakr@kernel.org, dri-devel@lists.freedesktop.org, hamohammed.sa@gmail.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, louis.chauvet@bootlin.com, lukas@wunner.de, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mairacanal@riseup.net, melissa.srw@gmail.com, mripard@kernel.org, quic_zijuhu@quicinc.com, rafael@kernel.org, robin.murphy@arm.com, rust-for-linux@vger.kernel.org, simona.vetter@ffwll.ch, simona@ffwll.ch, tzimmermann@suse.de Subject: Re: [PATCH v4 9/9] drm/vkms: convert to use faux_device Message-ID: References: <2025022643-scouting-petticoat-492b@gregkh> <20250311172054.2903-1-jose.exposito89@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250311172054.2903-1-jose.exposito89@gmail.com> On Tue, Mar 11, 2025 at 06:20:53PM +0100, José Expósito wrote: > Hi everyone, > > > On Tue, Feb 25, 2025 at 02:51:40PM +0100, Louis Chauvet wrote: > > > > > > > > > Le 25/02/2025 à 12:41, Thomas Zimmermann a écrit : > > > > Hi > > > > > > > > Am 10.02.25 um 15:37 schrieb Louis Chauvet: > > > > > On 10/02/25 - 13:30, Greg Kroah-Hartman wrote: > > > > > > The vkms driver does not need to create a platform device, as there is > > > > > > no real platform resources associated it, it only did so because it was > > > > > > simple to do that in order to get a device to use for resource > > > > > > management of drm resources. Change the driver to use the faux device > > > > > > instead as this is NOT a real platform device. > > > > > > > > > > > > Cc: Louis Chauvet > > > > > > Cc: Haneen Mohammed > > > > > > Cc: Simona Vetter > > > > > > Cc: Melissa Wen > > > > > > Cc: Maarten Lankhorst > > > > > > Cc: Maxime Ripard > > > > > > Cc: Thomas Zimmermann > > > > > > Cc: David Airlie > > > > > > Cc: dri-devel@lists.freedesktop.org > > > > > > Reviewed-by: Lyude Paul > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > Reviewed-by: Thomas Zimmermann > > > > > > > > > Tested-by: Louis Chauvet > > > > > Reviewed-by: Louis Chauvet > > > > > > > > > > Thanks for the modification, it seems to work. > > > > > > > > Should this patch be merged through DRM trees? drm-misc-next is at > > > > v6.14-rc4 and has struct faux_device. > > > > > > Hi, > > > > > > I was not aware the faux-device was merged, as it is a new feature, I > > > expected it to reach drm-misc-next on 6.15-rc1. > > > > I added it to Linus's tree just so that DRM could get these changes into > > their tree now :) > > > > > I plan to merge [1] today/tomorrow (well tested with platform_device), and > > > then I will submit an updated version of this patch (only trivial conflicts, > > > but never tested with multiple VKMS devices). > > > > > > [1]:https://lore.kernel.org/all/20250218101214.5790-1-jose.exposito89@gmail.com/ > > > > Great, thanks! > > > > greg k-h > > Testing this patch again as part of some IGT tests I'm working on, > I noticed that, applying this patch on top of the latest drm-misc-next > triggers a warning at drivers/gpu/drm/drm_gem.c:571, in > drm_gem_get_pages(): > >     if (WARN_ON(!obj->filp)) >             return ERR_PTR(-EINVAL); I forgot to mention that this warning is triggered just by `sudo modprobe vkms`. Sorry for the additional email. Jose > To double check that the cause were not my local changes, I checked > out commit 2d4d775d11d3 ("drm: pl111: fix inconsistent indenting > warning"), which doesn't contain any vkms config changes, applied this > patch and the result is the same. > > Louis, do you also see this warning? > > For reference, the log is at the end of this email. > Jose > > --- > > [  110.126952] [drm] Initialized vkms 1.0.0 for vkms on minor 1 > [  110.129193] faux_driver vkms: [drm] fb1: vkmsdrmfb frame buffer device > [  110.326759] ------------[ cut here ]------------ > [  110.326769] WARNING: CPU: 5 PID: 1106 at drivers/gpu/drm/drm_gem.c:571 drm_gem_get_pages+0x5e9/0x780 > [  110.326795] Modules linked in: vkms snd_seq_dummy snd_hrtimer snd_seq snd_seq_device snd_timer snd soundcore nf_conntrack_netbios_ns nf_conntrack_broadcast nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set rfkill nf_tables qrtr sunrpc binfmt_misc ppdev pktcdvd parport_pc e1000 parport i2c_piix4 pcspkr i2c_smbus joydev loop nfnetlink vsock_loopback vmw_vsock_virtio_transport_common vmw_vsock_vmci_transport vmw_vmci zram vsock bochs serio_raw ata_generic pata_acpi fuse qemu_fw_cfg > [  110.326892] CPU: 5 UID: 42 PID: 1106 Comm: KMS thread Not tainted 6.14.0-rc4+ #2 > [  110.326898] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-3.fc41 04/01/2014 > [  110.326902] RIP: 0010:drm_gem_get_pages+0x5e9/0x780 > [  110.326909] Code: 8d bd 78 fe ff ff e8 76 ca 8c fe 48 8d bd 78 fe ff ff e8 ea d9 8a fe e8 75 1a 17 01 e9 4b ff ff ff 48 8d 58 ff e9 6a fe ff ff <0f> 0b 49 c7 c7 ea ff ff ff e9 40 ff ff ff 0f 0b e9 0f fb ff ff 4c > [  110.326914] RSP: 0018:ffffc9000572f550 EFLAGS: 00010246 > [  110.326919] RAX: 1ffff11024531402 RBX: ffff88812298a000 RCX: 0000000000000000 > [  110.326923] RDX: dffffc0000000000 RSI: ffff8881125d54c8 RDI: ffff88812298a010 > [  110.326927] RBP: ffffc9000572f750 R08: 8000000000000063 R09: fffff52000ae5ef0 > [  110.326929] R10: ffffc9000572f787 R11: ffff888104638528 R12: 0000000000000000 > [  110.326932] R13: ffff88812298a168 R14: ffff88812298a0e8 R15: ffff88812298a190 > [  110.326936] FS:  00007f3cf4e536c0(0000) GS:ffff8883af080000(0000) knlGS:0000000000000000 > [  110.326940] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [  110.326944] CR2: 00007f3cd40337f8 CR3: 00000001394e4000 CR4: 00000000000006f0 > [  110.326951] Call Trace: > [  110.326954]   > [  110.326957]  ? show_regs.cold+0x19/0x1e > [  110.326965]  ? __warn.cold+0xbd/0x17f > [  110.326970]  ? drm_gem_get_pages+0x5e9/0x780 > [  110.326975]  ? report_bug+0x20b/0x2d0 > [  110.326982]  ? handle_bug+0x60/0xa0 > [  110.326988]  ? exc_invalid_op+0x1c/0x50 > [  110.326993]  ? asm_exc_invalid_op+0x1f/0x30 > [  110.327000]  ? drm_gem_get_pages+0x5e9/0x780 > [  110.327005]  ? kasan_save_stack+0x4d/0x60 > [  110.327011]  ? kasan_save_stack+0x3d/0x60 > [  110.327016]  ? kasan_save_track+0x1c/0x70 > [  110.327020]  ? kasan_save_alloc_info+0x3b/0x50 > [  110.327025]  ? __pfx_drm_gem_get_pages+0x10/0x10 > [  110.327029]  ? drm_atomic_helper_commit+0x7c/0x290 > [  110.327037]  ? dma_resv_get_singleton+0x99/0x2b0 > [  110.327043]  drm_gem_shmem_get_pages+0x69/0x1f0 > [  110.327048]  drm_gem_shmem_vmap+0x1f8/0x670 > [  110.327054]  drm_gem_shmem_object_vmap+0xd/0x20 > [  110.327058]  drm_gem_vmap+0x70/0xd0 > [  110.327063]  drm_gem_vmap_unlocked+0x4f/0xa0 > [  110.327067]  drm_gem_fb_vmap+0xaf/0x3c0 > [  110.327073]  vkms_prepare_fb+0x6e/0x80 [vkms] > [  110.327081]  drm_atomic_helper_prepare_planes+0x1a5/0xba0 > [  110.327088]  drm_atomic_helper_commit+0x128/0x290 > [  110.327092]  ? __pfx_drm_atomic_helper_commit+0x10/0x10 > [  110.327097]  drm_atomic_commit+0x203/0x2d0 > [  110.327101]  ? _raw_spin_lock_irqsave+0x97/0xf0 > [  110.327106]  ? __pfx_drm_atomic_commit+0x10/0x10 > [  110.327110]  ? __pfx___drm_printfn_info+0x10/0x10 > [  110.327116]  ? drm_event_reserve_init+0x1cd/0x260 > [  110.327123]  drm_mode_atomic_ioctl+0x1d2b/0x2d30 > [  110.327129]  ? __pfx_drm_mode_atomic_ioctl+0x10/0x10 > [  110.327134]  ? __kasan_check_write+0x18/0x20 > [  110.327140]  drm_ioctl_kernel+0x177/0x2f0 > [  110.327145]  ? __pfx_drm_mode_atomic_ioctl+0x10/0x10 > [  110.327149]  ? __pfx_drm_ioctl_kernel+0x10/0x10 > [  110.327155]  ? __kasan_check_write+0x18/0x20 > [  110.327160]  drm_ioctl+0x557/0xc90 > [  110.327165]  ? __pfx_drm_mode_atomic_ioctl+0x10/0x10 > [  110.327170]  ? __pfx_drm_ioctl+0x10/0x10 > [  110.327176]  ? selinux_file_ioctl+0x106/0x250 > [  110.327181]  ? fdget+0x2ca/0x3d0 > [  110.327185]  ? selinux_file_ioctl+0x106/0x250 > [  110.327191]  __x64_sys_ioctl+0x13c/0x1a0 > [  110.327198]  x64_sys_call+0xf3b/0x1d70 > [  110.327202]  do_syscall_64+0x82/0x160 > [  110.327208]  ? irqentry_exit+0x3f/0x50 > [  110.327213]  ? exc_page_fault+0x94/0x110 > [  110.327218]  entry_SYSCALL_64_after_hwframe+0x76/0x7e > [  110.327223] RIP: 0033:0x7f3d100fda6d > [  110.327234] Code: 04 25 28 00 00 00 48 89 45 c8 31 c0 48 8d 45 10 c7 45 b0 10 00 00 00 48 89 45 b8 48 8d 45 d0 48 89 45 c0 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 1a 48 8b 45 c8 64 48 2b 04 25 28 00 00 00 > [  110.327238] RSP: 002b:00007f3cf4e519b0 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > [  110.327244] RAX: ffffffffffffffda RBX: 00007f3cd402a440 RCX: 00007f3d100fda6d > [  110.327247] RDX: 00007f3cf4e51a50 RSI: 00000000c03864bc RDI: 0000000000000035 > [  110.327250] RBP: 00007f3cf4e51a00 R08: 00000000000000d0 R09: 0000000000000001 > [  110.327254] R10: 0000000000000003 R11: 0000000000000246 R12: 00007f3cf4e51a50 > [  110.327257] R13: 00000000c03864bc R14: 0000000000000035 R15: 00007f3cd4029f20 > [  110.327262]   > [  110.327264] ---[ end trace 0000000000000000 ]---