From: Oliver Mangold <oliver.mangold@pm.me>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Asahi Lina" <lina@asahilina.net>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/4] New trait OwnableRefCounted for ARef<->Owned conversion.
Date: Wed, 12 Mar 2025 09:19:27 +0000 [thread overview]
Message-ID: <Z9FRm8qkLRbdXq1F@mango> (raw)
In-Reply-To: <CANiq72mR66wn5T7WYCzyyan5dEQDQAyBvtzC381jfWgC6R8K9Q@mail.gmail.com>
On 250310 1642, Miguel Ojeda wrote:
> On Mon, Mar 10, 2025 at 11:57 AM Oliver Mangold <oliver.mangold@pm.me> wrote:
> >
> > - Squash patch to make Owned::from_raw/into_raw public into parent
>
> In this case, given the changes are minimal (and assuming you didn't
> discuss it with Lina), I would have personally used the [ ] notation
> to explain the change from the original patch, and that's it, rather
> than a Co-developed-by tag -- but do not worry about it :)
Sure, I would agree. I was mostly wondering about how the format for that
looks. You say [ ] notation. Could you maybe give an example for that?
> Also, in general, please wait at least a couple of days or ideally a
> week between versions (unless it is urgent etc.). Otherwise, it can
> get confusing for reviewers and so on.
Ok, sorry. New to this, you know.
Best regards,
Oliver
next prev parent reply other threads:[~2025-03-12 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 10:57 [PATCH v7 0/4] New trait OwnableRefCounted for ARef<->Owned conversion Oliver Mangold
2025-03-10 10:57 ` [PATCH v7 1/4] rust: types: Add Ownable/Owned types Oliver Mangold
2025-03-10 17:04 ` Boqun Feng
2025-03-10 10:57 ` [PATCH v7 2/4] rust: rename AlwaysRefCounted to RefCounted Oliver Mangold
2025-03-10 17:10 ` Boqun Feng
2025-03-10 10:57 ` [PATCH v7 3/4] rust: kbuild: provide `RUSTC_HAS_DO_NOT_RECOMMEND` symbol Oliver Mangold
2025-03-10 10:57 ` [PATCH v7 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted Oliver Mangold
2025-03-10 17:47 ` Boqun Feng
2025-03-12 10:37 ` Oliver Mangold
2025-03-10 15:42 ` [PATCH v7 0/4] New trait OwnableRefCounted for ARef<->Owned conversion Miguel Ojeda
2025-03-12 9:19 ` Oliver Mangold [this message]
2025-03-12 12:02 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9FRm8qkLRbdXq1F@mango \
--to=oliver.mangold@pm.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=lina@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).