From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-10631.protonmail.ch (mail-10631.protonmail.ch [79.135.106.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F231A23A571 for ; Wed, 12 Mar 2025 09:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.31 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741771177; cv=none; b=H3uix5S1FmYaDqsmxSpAVZ0RJc+4+yQvHgBmWr0Q1gaPAlX4Sqcmpv8MZrTBW3r2xmIBvLfFwscawrDJMl20bNY9EhRWt6lNLlWoXXoAd3vn9V7dJTov0G+o/yhMYMnKlXlbSfjjQ9wRoeD3ylnAFda50KK5/MrvyaMZP0knqoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741771177; c=relaxed/simple; bh=oBwEQFoOy8pOpeJ66KbTKgHr7VFOe1vin9j72U5w3HM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F+WXBgiyX+VO1AAghf/4ctz+LXCTZRGugdWOVNWjXTBwdIHjsx8+cL1rxSnyiwIxe2wfj182iY0TrnmFC01MfL16o2TKpIWIEYs1OhdCL+1T3HcVXT/+U3b+Ejyv+ro4F3+KGyJq0kRnHkNFGb4QwrtrKvJWqSraeZSKTMIrffg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me; spf=pass smtp.mailfrom=pm.me; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b=Wxk06aPJ; arc=none smtp.client-ip=79.135.106.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=pm.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pm.me Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pm.me header.i=@pm.me header.b="Wxk06aPJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1741771172; x=1742030372; bh=oBwEQFoOy8pOpeJ66KbTKgHr7VFOe1vin9j72U5w3HM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=Wxk06aPJC5cwC/KqcFNSguUqEo1fWtKJ28lendn5eccilWaeg/Z4ZFbky3AL4vP8B xY+FoAImNxGgee7UqLSJ9/eYNdZZUqome5i5Z3Qw4bYQASAhCYacWofWhux+QiOEzH 9BY8taYAdnzr+6fofg/e2DcNn0t8wHnWAWf6eZHnMziMpESPoDv+AcL6KA1ObLvsWl MmXCtdpNnVlheXjlK4lo6MXVpANkRMw7MJAMBsDp6q9o+/iiCEG2xtp3sm7s+tIWrv ynWn2mCSEt3tAyHcQH1eDHBUD9g1tN+ByG8+8jsnJg3zFHpVDQex3syVrHX78Ag7mk 9oikuojQnQ1gg== Date: Wed, 12 Mar 2025 09:19:27 +0000 To: Miguel Ojeda From: Oliver Mangold Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Asahi Lina , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/4] New trait OwnableRefCounted for ARef<->Owned conversion. Message-ID: In-Reply-To: References: <20250310-unique-ref-v7-0-4caddb78aa05@pm.me> Feedback-ID: 31808448:user:proton X-Pm-Message-ID: e8545f65ffc08a44b4e27e3f3091440b49be41b5 Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 250310 1642, Miguel Ojeda wrote: > On Mon, Mar 10, 2025 at 11:57=E2=80=AFAM Oliver Mangold wrote: > > > > - Squash patch to make Owned::from_raw/into_raw public into parent >=20 > In this case, given the changes are minimal (and assuming you didn't > discuss it with Lina), I would have personally used the [ ] notation > to explain the change from the original patch, and that's it, rather > than a Co-developed-by tag -- but do not worry about it :) Sure, I would agree. I was mostly wondering about how the format for that looks. You say [ ] notation. Could you maybe give an example for that? > Also, in general, please wait at least a couple of days or ideally a > week between versions (unless it is urgent etc.). Otherwise, it can > get confusing for reviewers and so on. Ok, sorry. New to this, you know. Best regards, Oliver