From: Danilo Krummrich <dakr@kernel.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
bhelgaas@google.com, ojeda@kernel.org, alex.gaynor@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v2 2/4] rust: device: implement device context marker
Date: Fri, 14 Mar 2025 18:31:48 +0100 [thread overview]
Message-ID: <Z9RoBMXWsrjg6jjg@cassiopeiae> (raw)
In-Reply-To: <67d465bb.050a0220.d2e19.8fc9@mx.google.com>
On Fri, Mar 14, 2025 at 10:21:58AM -0700, Boqun Feng wrote:
> On Fri, Mar 14, 2025 at 05:09:05PM +0100, Danilo Krummrich wrote:
> > Some bus device functions should only be called from bus callbacks,
> > such as probe(), remove(), resume(), suspend(), etc.
> >
> > To ensure this add device context marker structs, that can be used as
> > generics for bus device implementations.
> >
> > Reviewed-by: Benno Lossin <benno.lossin@proton.me>
> > Suggested-by: Benno Lossin <benno.lossin@proton.me>
>
> Try chronological order for the tags? It was suggested first and then
> reviewed.
Is that a thing? When I apply patches I usully keep ACKs, RBs and SOBs together
at the bottom.
next prev parent reply other threads:[~2025-03-14 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 16:09 [PATCH v2 0/4] Improve soundness of bus device abstractions Danilo Krummrich
2025-03-14 16:09 ` [PATCH v2 1/4] rust: pci: use to_result() in enable_device_mem() Danilo Krummrich
2025-03-14 16:09 ` [PATCH v2 2/4] rust: device: implement device context marker Danilo Krummrich
2025-03-14 17:21 ` Boqun Feng
2025-03-14 17:31 ` Danilo Krummrich [this message]
2025-03-14 17:43 ` Miguel Ojeda
2025-03-14 17:48 ` Boqun Feng
2025-03-14 16:09 ` [PATCH v2 3/4] rust: pci: fix unrestricted &mut pci::Device Danilo Krummrich
2025-03-14 16:09 ` [PATCH v2 4/4] rust: platform: fix unrestricted &mut platform::Device Danilo Krummrich
2025-03-14 17:28 ` [PATCH v2 0/4] Improve soundness of bus device abstractions Boqun Feng
2025-03-14 17:32 ` Danilo Krummrich
2025-03-15 8:34 ` Greg KH
2025-03-17 11:46 ` Danilo Krummrich
2025-03-17 13:17 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9RoBMXWsrjg6jjg@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).