From: Boqun Feng <boqun.feng@gmail.com>
To: Antonio Hickey <contact@antoniohickey.com>
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
aliceryhl@google.com, benno.lossin@proton.me,
bhelgaas@google.com, bjorn3_gh@protonmail.com,
brendan.higgins@linux.dev, dakr@kernel.org, davidgow@google.com,
fujita.tomonori@gmail.com, gary@garyguo.net,
gregkh@linuxfoundation.org, kunit-dev@googlegroups.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-pci@vger.kernel.org,
netdev@vger.kernel.org, ojeda@kernel.org, rafael@kernel.org,
rmoar@google.com, rust-for-linux@vger.kernel.org,
tmgross@umich.edu
Subject: Re: Re: [PATCH v3 2/3] rust: replace `addr_of[_mut]!` with `&raw [mut]`
Date: Sat, 15 Mar 2025 21:15:19 -0700 [thread overview]
Message-ID: <Z9ZQV7EbzeOPsUUU@Mac.home> (raw)
In-Reply-To: <010001959ce25be2-a436530e-858c-4da8-b823-24f98bad392b-000000@email.amazonses.com>
On Sun, Mar 16, 2025 at 02:57:15AM +0000, Antonio Hickey wrote:
> On Fri, Mar 14, 2025 at 05:18:17PM -0700, Boqun Feng wrote:
> > Besides, it'll be easy to review if you can split the changes into
> > multiple patches. Thanks!
>
>
> Hey Boqun,
>
> Thanks for the review, do you think splitting this patch
> into a seperate patch for each file would be best?
>
That'll be my suggestion. Although you could group a few changes
together for example, changes on rust/kernel/init.rs and
rust/kernel/init/macro.rs can be put into one patch. Thanks!
Regards,
Boqun
> Thanks,
> Antonio
>
next prev parent reply other threads:[~2025-03-16 4:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250314234148.599196-1-contact@antoniohickey.com>
2025-03-14 23:41 ` [PATCH v3 1/3] rust: enable `raw_ref_op` feature Antonio Hickey
2025-03-15 9:58 ` Benno Lossin
2025-03-14 23:41 ` [PATCH v3 2/3] rust: replace `addr_of[_mut]!` with `&raw [mut]` Antonio Hickey
2025-03-15 0:18 ` Boqun Feng
2025-03-16 2:57 ` Antonio Hickey
2025-03-16 4:15 ` Boqun Feng [this message]
2025-03-15 0:23 ` Boqun Feng
2025-03-15 9:47 ` Benno Lossin
2025-03-15 12:42 ` Boqun Feng
2025-03-14 23:41 ` [PATCH v3 3/3] rust: clippy: disable `addr_of!` and `addr_of_mut` macros Antonio Hickey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9ZQV7EbzeOPsUUU@Mac.home \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=brendan.higgins@linux.dev \
--cc=contact@antoniohickey.com \
--cc=dakr@kernel.org \
--cc=davidgow@google.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).