From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73ECA1E503D for ; Thu, 20 Mar 2025 08:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742460153; cv=none; b=TgRQHfa2sChS+qjVLUXW31bgL901gPVz/MdLGv2w1SbdYf7GU0OuSwE+w4Z0eRLRYrCNvzP3vgeilBGIRTiCg2wCjQmJ6rFrY9Gb+oibTrKFdAOHW0cDW+T+kgt4B8cnK63Za2bu/jFWwFmuYzDRsH/aZ2UcWk13NHJCllbWc3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742460153; c=relaxed/simple; bh=ETHNPzysFdBVxyexfBEmHBJj29mukUKke0l1rtbYB9E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TJiE/BJ4xsId+ofBVChn/ZNC62Fcw6sZidzc79Oi8l4cEVrXzRywGGPYma32dXKZrX/zbPeQrXoMiWew3PheJ1OdW1zfBrB7z3u3UEFN47mnBkHh1UrlAfGnzb2zm1XryEseYJRZ2+ofJGsOTZp788KzxS3bPrxZFB3AVkvlwn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qHBDNMPD; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qHBDNMPD" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so4224035e9.2 for ; Thu, 20 Mar 2025 01:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742460150; x=1743064950; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0q/pCfHYYPtBzoXiRpe1vIV+5BdA4Fjd+4hDTSR/RtY=; b=qHBDNMPDWXPKlaYZyGt0POBWgiaLkzlnlpdkGeUReduF8XtrJTJl4XrlSFKZR/s2jI OSdorvzXaa7I2MlLCXyu8Vvm0osY0tgscpFd26j8D/xjV6QPrYSLtKaNNzxqIu/Bu+EW V6mdpeQpQjWsfNuhjG7Oh0L+vZKtl41D7sqmyO7djN3lzUPxa1gFSYMDuEeB2UPVHTeu Xk6ScYCEmog6RhAspVIOy4ua8ZWRktXpIi+lPbZeJ4S52k7ZdfWE8y7rqX6O8qNKjcJH dRYHjCr6OQ1a1eDS3hSXr0N/tWoR5vNfe0NxzQ3zozFrMQohFannVazBmGdiJV1f7Ri4 Maug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742460150; x=1743064950; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0q/pCfHYYPtBzoXiRpe1vIV+5BdA4Fjd+4hDTSR/RtY=; b=M5ZYcMGSFplxfmIzyJyMKNDpb1DW6AW4r6jm5UIdKzGAb3p08RIRgI+n9MIG+UFF1N 73m3+CsFBx4DaGY6I3sYg60VUNRC/nVBv9aAeV2M/h7PXWI10eoXHYX3FS2jI+szxCcm Sbqv4VU0EQ9GMY71Od8QwLNDJ8CbcR/WHUV6lzkMZQHxsY6MtdGqzoZm4ZY15OW1dhf+ Ry/gqXuxcy/57h5n6V8YALJ+wno2n0TDK/DWMmGE6dMO3KhvUU32s2Om37m9SZZ6Qwl9 q8DkOGaC99YCN1+aOj0VkYilLJ5XAiowKGijJFRdTWf3HYmAB+z5Fen9SmC05Ck1EZjJ ib1g== X-Forwarded-Encrypted: i=1; AJvYcCVmvEcetgUrj5Ovr8UsF8If7vwPY9OZV2/bg1yCe3BobK8eHmMFF8BcvRrcu7Via1/9ivoK40UhbMX5TmkkUw==@vger.kernel.org X-Gm-Message-State: AOJu0Yz1hVI922TMVr1EvXX7xfeclwXlxBKZyJ1p7OzbpngTtwYfxkbS GHDyJ/v+ilJn8RbhwukrDX4TQO+jQWvUls7GasPlAyV1wdyc2U2Z0Uhy0GyqLw9dFhiV03tq+OP k/pBBtVT7Bsk6+Q== X-Google-Smtp-Source: AGHT+IG0ZxbKLoTEaoTwO913p2LfPABAlZp2ArpAG4/VyJdVxYakp4RPsHWiV0l8Ao9KV2sMc4Ra47lUkav23Ig= X-Received: from wmbbd5.prod.google.com ([2002:a05:600c:1f05:b0:43c:f6c0:3375]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3d18:b0:43d:738:4a9 with SMTP id 5b1f17b1804b1-43d495bd8f2mr14990235e9.27.1742460149944; Thu, 20 Mar 2025 01:42:29 -0700 (PDT) Date: Thu, 20 Mar 2025 08:42:28 +0000 In-Reply-To: <20250317025205.2366518-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250317025205.2366518-1-kunwu.chan@linux.dev> Message-ID: Subject: Re: [PATCH v2] rust: sync: optimize Rust symbol generation for PollCondVar From: Alice Ryhl To: Kunwu Chan Cc: ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@kernel.org, tmgross@umich.edu, dakr@kernel.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Kunwu Chan , Grace Deng Content-Type: text/plain; charset="utf-8" On Mon, Mar 17, 2025 at 10:52:05AM +0800, Kunwu Chan wrote: > From: Kunwu Chan > > When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64 > with ARCH=arm64, the following symbols are generated: > > $nm vmlinux | grep ' _R'.*PollCondVar | rustfilt > ... T ::new::{closure#0}::{closure#0}::panic_cold_explicit > ... T ::drop > ... T ::drop > > This Rust symbol > (::drop) > is trivial wrappers around the C functions __wake_up_pollfree > and synchronize_rcu. It doesn't make sense to go through a trivial > wrapper for its functions,so mark it inline. > > Link: https://github.com/Rust-for-Linux/linux/issues/1145 > Suggested-by: Alice Ryhl > Co-developed-by: Grace Deng > Signed-off-by: Grace Deng > Signed-off-by: Kunwu Chan Reviewed-by: Alice Ryhl