rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boqun Feng <boqun.feng@gmail.com>
To: "Björn Roy Baron" <bjorn3_gh@protonmail.com>
Cc: Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Wedson Almeida Filho <wedsonaf@gmail.com>,
	Gary Guo <gary@garyguo.net>,
	Benno Lossin <benno.lossin@proton.me>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl
Date: Sun, 25 Jun 2023 16:13:51 -0700	[thread overview]
Message-ID: <ZJjKL968vGuNeNmL@boqun-archlinux> (raw)
In-Reply-To: <R7bIOWHPBelVxutK-V8lFrSCh_diCIJtJxP-HbOJDV0i2VaKriARSwBRv8TaTevuT06lySKkBALLFJ8S_7q2Qzzr2fH4eceYXYO1_kp1jnI=@protonmail.com>

On Sat, Jun 24, 2023 at 02:40:23PM +0000, Björn Roy Baron wrote:
> On Friday, June 23rd, 2023 at 19:35, Boqun Feng <boqun.feng@gmail.com> wrote:
> 
> > On Thu, Jun 22, 2023 at 09:24:40PM +0200, Björn Roy Baron via B4 Relay wrote:
> > 
> > > From: Björn Roy Baron bjorn3_gh@protonmail.com
> > > 
> > > While there are default impls for these methods, using the respective C
> > > api's is faster. Currently neither the existing nor these new
> > > GlobalAlloc method implementations are actually called. Instead the
> > > _rust* function defined below the GlobalAlloc impl are used. With
> > > rustc 1.71 these functions will be gone and all allocation calls will go
> > > through the GlobalAlloc implementation.
> > > 
> > > Link: https://github.com/Rust-for-Linux/linux/issues/68
> > 
> > 
> > Nice! Although I think we need to do the simialr size adjustment as:
> > 
> > 	https://lore.kernel.org/rust-for-linux/20230613164258.3831917-1-boqun.feng@gmail.com/
> > 
> > so I applied your patch onto my patch and came up with the following:
> 
> Right. That patch LGTM.
> 

Thank you and Gary for the diff review, I will fold it into your
original patch and resend.

Regards,
Boqun

> Cheers,
> Björn

  reply	other threads:[~2023-06-25 23:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 19:24 [PATCH] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl Björn Roy Baron via B4 Relay
2023-06-23  1:07 ` Martin Rodriguez Reboredo
2023-06-23 17:35 ` Boqun Feng
2023-06-24 14:40   ` Björn Roy Baron
2023-06-25 23:13     ` Boqun Feng [this message]
2023-06-25 20:39   ` Gary Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJjKL968vGuNeNmL@boqun-archlinux \
    --to=boqun.feng@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=wedsonaf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).