From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E82EB64D7 for ; Mon, 26 Jun 2023 16:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229571AbjFZQju (ORCPT ); Mon, 26 Jun 2023 12:39:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229780AbjFZQjY (ORCPT ); Mon, 26 Jun 2023 12:39:24 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 758A412B; Mon, 26 Jun 2023 09:39:23 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-514ab6cb529so8225667a12.1; Mon, 26 Jun 2023 09:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687797562; x=1690389562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=A0YJn0nHiYyufMIyUTdFjE9mnzWA8s9uE9k4SjNMK5s=; b=GZeizG6Y4PaChSHpvyiDYh3iTPUXokimKII0T07Fur1zyhiQSfhWhHxMh5ivPLEXyh sxXLs62NU1jalfM3KweVDlbLrD/BdGsrn9juk0+DKDKwZJZbXY4cYprCIbRgq8VI3knM lMRNTD6R8+j8aOUmhrqtIPNGxRDKqbQtGsMWvHYRZNIEXg2FUXH6ijYQW91JZIDE89QJ Ca9fFrCarTkJwPKS7iYHcC0F0rgNu/Dsz5RYyU78ocmeDeHksxI5Uq0KAqhQAt/c8/dk lD+Ckkx8M7UilUv0LxdbReBAqLioQAXP9V/8gO3EqkUJ4VfTbGFxPPeeBvHdXe76JpdA r9pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687797562; x=1690389562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A0YJn0nHiYyufMIyUTdFjE9mnzWA8s9uE9k4SjNMK5s=; b=FlqpCbfdkJK8jyS81nQPjKQmwwECH3yhIlbTZ6j5ImKT6vXoFdfr+fqEhpVbzbC1nt Paqm4kUCi2lNvjJs9q5VPjpocwyc7mq7/ykeKHOtAZEty9VDn8LjF7wYmeL/ST9QkqR8 qxZTXwYi4b6/a6LOoa1sM2UXLPDcIPhuIku/8f6KN7qLVgIjZ6JDNWljGbQhzBdqg0VR 15aDrB0EN8rWRFb5OpB7XUedZWZ9CESC/o10suGoOc6PAwXHiEogCso44qmj66tyN5qh rsvf4cliLPz2tCIJ7wHnODIY8plnPKZInv78jxhQR7AHqfd91lWJKu2Ak6V2kv+RoVIs VdWA== X-Gm-Message-State: AC+VfDx7XJLEwj6ta9jmdup+KqiFqi5Lkr3LeT9XdjLXotHReFDdAUES 5SkpBQCLC0Q2nGb5macuqQ0= X-Google-Smtp-Source: ACHHUZ65FFaYZOMnb2NYEdhtimMGXfw91PZindVZLIjmgybiR9JefPGCDY+RV9uFwfDZqd3ZieDw0g== X-Received: by 2002:a05:6402:270d:b0:51a:4451:564d with SMTP id y13-20020a056402270d00b0051a4451564dmr25044141edd.18.1687797561651; Mon, 26 Jun 2023 09:39:21 -0700 (PDT) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id ba30-20020a0564021ade00b0050a276e7ba8sm2953327edb.36.2023.06.26.09.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 09:39:20 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 5FE7627C005A; Mon, 26 Jun 2023 12:39:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 26 Jun 2023 12:39:18 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeehfedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpefhtedvgfdtueekvdekieetieetjeeihedvteehuddujedvkedtkeefgedv vdehtdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhh phgvrhhsohhnrghlihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunh drfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Jun 2023 12:39:16 -0400 (EDT) Date: Mon, 26 Jun 2023 09:39:01 -0700 From: Boqun Feng To: Qingsong Chen Cc: Greg KH , linux-kernel@vger.kernel.org, =?utf-8?B?55Sw5rSq5Lqu?= , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Vincenzo Palazzo , Asahi Lina , rust-for-linux@vger.kernel.org Subject: Re: [RFC PATCH 1/8] rust: kernel: add basic abstractions for device-mapper Message-ID: References: <20230625121657.3631109-1-changxian.cqs@antgroup.com> <20230625121657.3631109-2-changxian.cqs@antgroup.com> <2023062544-speech-impish-9308@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On Mon, Jun 26, 2023 at 11:26:12AM +0800, Qingsong Chen wrote: > On 6/25/23 8:25 PM, Greg KH wrote: > > Shouldn't this be all different commits, and different files? A bio > > shouldn't be defined in the device_mapper.rs file, as that would prevent > > anyone else from accessing it. > > Yes, you're right. Since we noticed that some block layer patches[1] > are under review, we don't put much effort into that. Actually, we > don't want to include all the `bio` implementation in this patchset, > so it just some dummy codes. > > If necessary, a seperate commit could be splited, including things > that do not belong to the device mapper. > Maybe you can just base on one or all the patches from Andreas' series (and mention the dependency in the cover letter)? Regards, Boqun > [1]: https://lore.kernel.org/rust-for-linux/20230503090708.2524310-5-nmi@metaspace.dk/ > > Thanks, > Qingsong Chen