From: Philip Li <philip.li@intel.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
kernel test robot <lkp@intel.com>,
Yujie Liu <yujie.liu@intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
<rust-for-linux@vger.kernel.org>, <llvm@lists.linux.dev>,
<oe-kbuild-all@lists.linux.dev>,
Jacob Keller <jacob.e.keller@intel.com>,
<intel-wired-lan@lists.osuosl.org>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
<linux-hardening@vger.kernel.org>,
Kees Cook <keescook@chromium.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs
Date: Fri, 18 Aug 2023 20:07:55 +0800 [thread overview]
Message-ID: <ZN9fG8rPmdFO0kLK@rli9-mobl> (raw)
In-Reply-To: <CANiq72m9ZEVkP76FMFOnPYkA8ih4Mq72HtW9AbrJ-JPy9ku3jw@mail.gmail.com>
On Fri, Aug 18, 2023 at 01:10:07PM +0200, Miguel Ojeda wrote:
> On Fri, Aug 18, 2023 at 12:38 PM Przemek Kitszel
> <przemyslaw.kitszel@intel.com> wrote:
> >
> > Rust folks, could you please tell me if this is something I should fix,
> > or I just uncovered some existing bug in "unstable" thing?
> >
> > Perhaps it is worth to mention, diff of v3 vs v2 is:
> > move dummy implementation of __has_builtin() macro to the top of
> > compiler_types.h, just before `#ifndef ASSEMBLY`
>
> Nothing you need to worry about, it is an issue with old `bindgen` and
> LLVM >= 16, fixed in commit 08ab786556ff ("rust: bindgen: upgrade to
> 0.65.1") which is in `rust-next` at the moment. Sorry about that, and
> thanks for pinging us!
>
> LKP / Yujie / Philip: since we got a few reports on this, would it be
> possible to avoid LLVM >= 16 for Rust-enabled builds for any branch
> that does not include the new `bindgen` or at least 08ab786556ff? Or,
Got it, we will update the bot to handle this to avoid further false
positive.
> if Greg is OK with that, I guess we could also backport the upgrade,
> but perhaps it is a bit too much for stable?
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2023-08-18 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230816140623.452869-2-przemyslaw.kitszel@intel.com>
[not found] ` <202308170000.YqabIR9D-lkp@intel.com>
2023-08-18 10:37 ` [PATCH net-next v3 1/7] overflow: add DEFINE_FLEX() for on-stack allocs Przemek Kitszel
2023-08-18 11:10 ` Miguel Ojeda
2023-08-18 12:07 ` Philip Li [this message]
2023-08-19 10:06 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN9fG8rPmdFO0kLK@rli9-mobl \
--to=philip.li@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=przemyslaw.kitszel@intel.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).