From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1726189B80 for ; Wed, 16 Apr 2025 10:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744799896; cv=none; b=cXc6d6ix0C4JAa9HfgMrHbVvNLM7p8Hyr6cTZ49722+bInv1dwrTy9BXdkKBSLXGaBoU0Z4tB7kpUxEP5m9K+vgUAdAgQqZEkbTo8XmqW1Ysh3fNHTTi9kPLjeOkw11k/iAK9tInicC9VRqiMTP3RMJVrye8rxHU6pK9GEAq5F0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744799896; c=relaxed/simple; bh=/498mwjfnYlCU9pyZvO9bEzZdwQsgiwBm51YqjQFjmE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IisGi3rWFJXSHUkESiKjvPaBdfDTblGbcIZP6e/2CtSlkRjXWPfOcl05DBS0QKqLqjoY2fv/uX+biCfTcy3N8tgrmZRGSb1bcBp1ljTwbUq5kFAukHVg5jUga6HvQip4Z8urUgqYGXWUn3EFlz/D/zFqIfCg9Lk5N+9Vt0DDo4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Iu3rSvub; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Iu3rSvub" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso3124905e9.0 for ; Wed, 16 Apr 2025 03:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744799893; x=1745404693; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=Wj93qOMqFHl3tcMBbmsDJQxqfd74N+Y5rsy/X8u5r9M=; b=Iu3rSvubryFwZ4BMUNDRg5vKnlBAIxIlaEe5qjdNGwfMHpu0EOu4ooF94O5EMz97I9 Yhijh3MLa05ZLnMbaY9ZUURhThdNjYdPufVpZMZG/fKn7LOO1v7sUp4aoWlbdN/8H+9O Av6WIafAf+ALhsJ0Rf9zRWnv1cwFtO/jJQqN2vvK1cBqG8IPfIHpPuOoPPiPVDCXDaai Ci3RiL82UwCr4uMzZAZTcueWI1okHh/6FyMoX74uL42eIH344w7bdJqX1WEfPlJ9H+b4 GyJcFIBp3WZV0f+9yocIBid+CmpAHTOqJ4gTSAPvEiMGo4jc355gEh0y+gmhLt9yPy4S A2Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744799893; x=1745404693; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Wj93qOMqFHl3tcMBbmsDJQxqfd74N+Y5rsy/X8u5r9M=; b=LfULXie7gToLuZIxNoaAvGsn0941kT0j+2FAvL4dYU68GakFRIxEUs0lkUVICFQakR cOBllVzx/7AhjQeoR5j3k+dgn4xHyx/kZNOcE4kOXfBRMcwRNO9eW3lqpaMpZyVDEd3Y cIDLZ3aEN0UB1ggKI79Qp2z6r37kCEUHHLatFjwWc1gP7GXE+Mg7lqqy6k30568V4OCx rRZKh+zzjEBdrbLO+yEQPjOjW4/bnngvRJQ3ze0vV/08NKgRktHdwj9ZZmqVjTAdU7dJ fKUfjAqC2oLFCvYurTUEB0vMcKy9DPQfrmDTO5PagIpHUqFmxrro/+AfWmldppmxgEIf 1tMQ== X-Forwarded-Encrypted: i=1; AJvYcCWhL2GqRVNruG1BYPd51mqYRYPIeCM317bZVoT6eebarfchNUnkL/qMVgSAXeKfSfLIuSD/qjZbBh1wDM6x/Q==@vger.kernel.org X-Gm-Message-State: AOJu0YwmIStSMBTyZH6x0ZYu/j8+Kxn95pvhTHHeBZkggi6fra+8RG4O vecBcJr7fL5EO9dCwFTJFXbjUMf4MS7iNkVWWEkyJ9Pj3VQiEDqisIgWhSxLkfaaOjdGeRQU2Mm wbqBoTo7HIaHBcw== X-Google-Smtp-Source: AGHT+IH32aeGBvg2luv4gbioBUWBNQHausYBBTdgS9H6mIAClBxo2uw9CdlM5sOoYtH0AQXXEFBt8D2/a5SUY7U= X-Received: from wmqb15.prod.google.com ([2002:a05:600c:4e0f:b0:43d:abd:278f]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a7b:cd14:0:b0:43d:fa5f:7d04 with SMTP id 5b1f17b1804b1-4405d7f3ffbmr12296315e9.16.1744799892884; Wed, 16 Apr 2025 03:38:12 -0700 (PDT) Date: Wed, 16 Apr 2025 10:38:10 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250410115420.366349-1-panikiel@google.com> <20250410123602.GZ9833@noisy.programming.kicks-ass.net> <20250410124526.GB9833@noisy.programming.kicks-ass.net> <20250410130944.GA9003@noisy.programming.kicks-ass.net> <20250410132649.GE9833@noisy.programming.kicks-ass.net> <20250410133446.GF9833@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH] x86/Kconfig: make CFI_AUTO_DEFAULT depend on !RUST From: Alice Ryhl To: Miguel Ojeda Cc: Peter Zijlstra , "=?utf-8?B?UGF3ZcWC?= Anikiel" , Sami Tolvanen , Kees Cook , Alex Gaynor , Borislav Petkov , Dave Hansen , Ingo Molnar , Josh Poimboeuf , Masahiro Yamada , Miguel Ojeda , Thomas Gleixner , Nathan Chancellor , x86@kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Matthew Maurer , Ramon de C Valle Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 15, 2025 at 05:15:31PM +0200, Miguel Ojeda wrote: > On Thu, Apr 10, 2025 at 4:00=E2=80=AFPM Alice Ryhl = wrote: > > > > I submitted a PR that I believe should fix it: > > https://github.com/rust-lang/rust/pull/139632 >=20 > This landed, scheduled for Rust 1.88 (2025-06-26) if all goes well. >=20 > Peter: are you OK with landing a patch like this? Well, modified to > look like this now that we know the version: >=20 > depends on FINEIBT > depends on !RUST || RUSTC_VERSION >=3D 108800 >=20 > (assuming we confirm the nightly build works properly) With that change: Reviewed-by: Alice Ryhl I have tested locally that the upstream PR works together with CFI, although I did it by backporting the PR to the rustc version I'm using rather than by using the latest nightly. Not sure if a Tested-by on *this* patch is warranted from that test ... but if you think so feel free to add that too. Alice