From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EA6027585D for ; Mon, 14 Apr 2025 14:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744639672; cv=none; b=o3PBhFW7xXd4vUt09gjC6ebMhhVaNL8BsUbp96QtlPd4ImSpEX2f0OSTStESFxu0LfnnQO6+gJB7q/6DI7xA3raFaCnKhBT4mbbkpAl7TjzejSyQPW/55AY38kPbMHipxby8SaCAlwaR4R/tQtiSGc/PK4N3MeXItw0Q4VZrzuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744639672; c=relaxed/simple; bh=AYWkkj9NyBWLE+vHeCXHgbQh4tX6WsCz2DwqzolPXQc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=PCCwM3EndDMNbeIQmLqSFp1BpkkpeEyYZpxQvGnExjp86+Tha7r+dQ+opZwgXrBxJNUsQB+qoUpe+m8wyzhsW5pUiBEOQwv6A5L4aXgQnqGacs5utLhaHUM8qv3QB4uHUoXMdfMLROOAc8fwHQgJbdAz2zELUE9+ho2kL9tLUZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ipXhlbOv; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ipXhlbOv" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-43f405810b4so14737035e9.1 for ; Mon, 14 Apr 2025 07:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744639668; x=1745244468; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=99k4XkFNDnG3EsiHLB6vmh114esekQLkfPzps9wZH3s=; b=ipXhlbOvvW8tOfQXgeqpXiKHRjCloi8PAp1SHqDO+YFdqx47gk/va9gz0DkJ87mLUd wkR9SeecTd6le3K+82/apQZwRTbCNGEVPTcZeo4Vk2zFA9brhS5zwnWLk/NzTsX9NKL3 ZHHL8HEl4LGe20gK48B8imfXxRM3nm7TIXcWl5rpink1UPPGW0DEsOD2OXlQ3NXlsbSs f1wZSGnkJsM2GkAXeDaHHBT318wkNL25QzZmQVw+JR5Eu8dnPRVL+CtoxBzXZ5fsIntK pfuHdJX6i6bBKP7WcaoOhDO7Klysz8L3lNZwBGAePSABkc+7PikVzhKsx6kA/bI0ZWL4 j65Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744639668; x=1745244468; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=99k4XkFNDnG3EsiHLB6vmh114esekQLkfPzps9wZH3s=; b=E02we3/y4htJW+Qsz1PQsBvCZ0BBI9lAELQ5X2rxwvnWshJ8d+U4yM0N/zj86c4cmg ApbX/I8q7JWOGEjmiAgLy8+VYb8qEXXyBKDuA/0dHZ82w3mGrstdyxYymtVFW9vTF6dA 0rUzxNkcyaTCu2kNL3eOHMXzH48jYgC4vPuE7Qj+K7/LpBxGyXpWCKgWjKjmKUK5Oofv fJYbWJQ3AOM/Bt/loBIYMOQ7sACgRr0feHsu9dRRL9l4rLd8S8PbWZyQMtDIGGLOGEqt eLIhpIbaFOMHn4SFUv4E/FHds8VOFXM4mJCk2E5JDZO1D6ozB6GQWecSu4ZenHCGMgF5 EWsw== X-Forwarded-Encrypted: i=1; AJvYcCWoLjVr4X9hJioRc/azmnNAxsAjtkuZC+NVJ2VXDydw5spLOGD0WsI0eVTuTYF1ZV6vHlo7CweUnakfmWaBmQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy20g04uT0H9AU1VqX1CXgPoa1mYQUQA6lr7gdoZ0iEwnBV83JA Ye7iJbwK/102lavDgL1K8pS5pf5mHa4Sat43bm5GnVOci3AAUq9ZjFeCSlZfq28VikC66sgeDFy VrPxGK6um+KUaZA== X-Google-Smtp-Source: AGHT+IEN9Rftc6XcCDbvh31R9vqfEr61DrJmd3at5EtnCIlCs+9Wd11hNl1/CdDZ62/r1z3umTWHKnoW1ogWl8g= X-Received: from wmbgz6.prod.google.com ([2002:a05:600c:8886:b0:43c:f517:ac4e]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1f94:b0:43b:ca39:6c7d with SMTP id 5b1f17b1804b1-43f3a925899mr111059205e9.3.1744639668562; Mon, 14 Apr 2025 07:07:48 -0700 (PDT) Date: Mon, 14 Apr 2025 14:07:46 +0000 In-Reply-To: <20250413002338.1741593-1-ojeda@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250413002338.1741593-1-ojeda@kernel.org> Message-ID: Subject: Re: [PATCH] objtool/rust: add one more `noreturn` Rust function From: Alice Ryhl To: Miguel Ojeda Cc: Josh Poimboeuf , Peter Zijlstra , Alex Gaynor , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, stable@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Sun, Apr 13, 2025 at 02:23:38AM +0200, Miguel Ojeda wrote: > Starting with Rust 1.86.0 (see upstream commit b151b513ba2b ("Insert null > checks for pointer dereferences when debug assertions are enabled") [1]), > under some kernel configurations with `CONFIG_RUST_DEBUG_ASSERTIONS=y`, > one may trigger a new `objtool` warning: > > rust/kernel.o: warning: objtool: _R..._6kernel9workqueue6system() > falls through to next function _R...9workqueue14system_highpri() > > due to a call to the `noreturn` symbol: > > core::panicking::panic_null_pointer_dereference > > Thus add it to the list so that `objtool` knows it is actually `noreturn`. > > See commit 56d680dd23c3 ("objtool/rust: list `noreturn` Rust functions") > for more details. > > Cc: stable@vger.kernel.org # Needed in 6.12.y and later (Rust is pinned in older LTSs). > Fixes: 56d680dd23c3 ("objtool/rust: list `noreturn` Rust functions") > Link: https://github.com/rust-lang/rust/commit/b151b513ba2b65c7506ec1a80f2712bbd09154d1 [1] > Signed-off-by: Miguel Ojeda Reviewed-by: Alice Ryhl