From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: a.hindborg@samsung.com, alex.gaynor@gmail.com,
benno.lossin@proton.me, bjorn3_gh@protonmail.com,
gary@garyguo.net, linux-kernel@vger.kernel.org, ojeda@kernel.org,
rust-for-linux@vger.kernel.org, wedsonaf@gmail.com
Subject: Re: [PATCH v3 2/2] rust: sync: add `Arc::into_unique_or_drop`
Date: Wed, 13 Mar 2024 10:12:44 -0700 [thread overview]
Message-ID: <ZfHejEkGKPPHPx05@boqun-archlinux> (raw)
In-Reply-To: <20240313095059.844387-1-aliceryhl@google.com>
On Wed, Mar 13, 2024 at 09:50:59AM +0000, Alice Ryhl wrote:
> Boqun Feng <boqun.feng@gmail.com> writes:
> > The code looks good, and FWIW, I added the Examples section for the
> > function since I at least need something to run when queuing it to
> > rust-dev branch ;-) And I think it's overall good to have examples for
> > every `pub` function. If there is a next version (which is unlikely),
> > feel free to fold it. I can also send it alone once Miguel put your
> > patches into the rust-next branch.
>
> Thanks! If you have reviewed it, could I have your Reviewed-by tag?
>
Done.
> > From 7d26d1177a2788ba96c607fd9dc45baf469fb439 Mon Sep 17 00:00:00 2001
> > From: Boqun Feng <boqun.feng@gmail.com>
> > Date: Tue, 12 Mar 2024 10:03:39 -0700
> > Subject: [PATCH] kernel: sync: Add "Examples" section for
> > Arc::into_unique_or_drop()
> >
> > These examples provide better documentation and can serve as unit tests
> > as well, so add them.
> >
> > Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
>
Thanks! I will add it.
Regards,
Boqun
> Alice
next prev parent reply other threads:[~2024-03-13 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 16:08 [PATCH v3 0/2] Arc methods for linked list Alice Ryhl
2024-03-11 16:08 ` [PATCH v3 1/2] rust: sync: add `ArcBorrow::from_raw` Alice Ryhl
2024-03-11 16:08 ` [PATCH v3 2/2] rust: sync: add `Arc::into_unique_or_drop` Alice Ryhl
2024-03-11 17:41 ` Benno Lossin
2024-03-12 17:28 ` Boqun Feng
2024-03-13 9:50 ` Alice Ryhl
2024-03-13 17:12 ` Boqun Feng [this message]
2024-03-13 17:08 ` [PATCH v3 0/2] Arc methods for linked list Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfHejEkGKPPHPx05@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).