From: Danilo Krummrich <dakr@redhat.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Andrew Ballance <andrewjballance@gmail.com>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org, mcgrof@kernel.org,
russ.weight@linux.dev, ojeda@kernel.org, alex.gaynor@gmail.com,
wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@samsung.com, aliceryhl@google.com,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] rust: firmware: fix invalid rustdoc link
Date: Mon, 8 Jul 2024 13:25:43 +0200 [thread overview]
Message-ID: <ZovMt7AHJdiGEobg@pollux> (raw)
In-Reply-To: <CANiq72mB3hA6GeN2XSqRpV4m+rCbr2+NLHgmfpphjm1Wo1wBBw@mail.gmail.com>
On Mon, Jul 08, 2024 at 11:16:34AM +0200, Miguel Ojeda wrote:
> On Mon, Jul 8, 2024 at 11:07 AM Andrew Ballance
> <andrewjballance@gmail.com> wrote:
> >
> > rustdoc generates a link to a nonexistent file because of a extra quote
> >
> > Signed-off-by: Andrew Ballance <andrewjballance@gmail.com>
>
> Thanks for the patch!
>
> I guess this is meant for staging/rust-device, but I think this should
> be a review comment here:
Firmware and device abstractions were merged in driver-core-next.
>
> https://lore.kernel.org/rust-for-linux/20240618154841.6716-3-dakr@redhat.com/
>
> Cheers,
> Miguel
>
next prev parent reply other threads:[~2024-07-08 11:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 9:06 [PATCH] rust: firmware: fix invalid rustdoc link Andrew Ballance
2024-07-08 9:16 ` Miguel Ojeda
2024-07-08 11:25 ` Danilo Krummrich [this message]
2024-07-08 11:56 ` Miguel Ojeda
2024-07-09 0:44 ` [PATCH v2] " Andrew Ballance
2024-07-13 14:49 ` Danilo Krummrich
2024-07-14 6:16 ` Greg KH
2024-07-08 11:24 ` [PATCH] " Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZovMt7AHJdiGEobg@pollux \
--to=dakr@redhat.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).