From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E48E80624 for ; Mon, 8 Jul 2024 11:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720437952; cv=none; b=hc4vw08sPIy8YpJEOTu8rasya5EtXAN/G7iiG57kzgVpheXDo/0NW6ePkAZt+MASNmHPQALicxe4PDx3WoOeefQNYvfScXb0Z0IESH4DIcYWqNDjcE3suHBxyhRVfIvUJaCHp1sYkTs5yZ1nZujSGvmD2jT5KfTkCISMEasrGMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720437952; c=relaxed/simple; bh=iKpwXvhbB0qXDjkBNWkywakk5y4ndG5jn1tceNaYV8c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=rYP/pusSQyzyFtk4/S5Oanrtfn+CQWEBgf53LiZBPdj97rJej7LJSo8wMxGEfRJaKojZkSGF7/CQSaFSbe0iChcGAabnucggKL1RV0JYyZtEbFKnBjc2Bxf0D0biqzJGg+HjZc5ahF4swWie5drB8vyD1/knT1zTFpL6KnvWm9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cYatXQ5b; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cYatXQ5b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720437949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rxDEKjje7ewX3dmdPxps0vgNGDNpfSpWeAQAGsyxyvw=; b=cYatXQ5bounifFgmAZm4rkzbj6GPRwP5q3aSHNh8jEdRvwIdtzkDU3ckHiz99/X8ctAb9v 8KTb+rCvz4bSDSaOG9efDD4pu/G3Cg85kXSxUFBjaWB9iz9pA937fPUlqxRhnXWdZEldgH yWS3IEeStpatAJHPcVQi86Q+4D50x0U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-u5sA0aIsNRKdjCj4rMOTzg-1; Mon, 08 Jul 2024 07:25:47 -0400 X-MC-Unique: u5sA0aIsNRKdjCj4rMOTzg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-426683d9c4bso6281135e9.3 for ; Mon, 08 Jul 2024 04:25:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720437946; x=1721042746; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rxDEKjje7ewX3dmdPxps0vgNGDNpfSpWeAQAGsyxyvw=; b=CScBYd09tlJ5mSwH962uktgR4uQnn0EYeEd6fx0SlMGQ4AST1ztt2fk6u/3vD3jUUg G03v2v48Foye8HdVRy9pqcaHpYgjO8+lViYXX+QAePblgGTkYeb8bUkMJZuysKncTCCA cVjK1yOUuI2L/mxhilwBNX7cHeRIC/3xpysP/3vXNYh+Sd99bUwZbWbs2HftS6I92qnZ YKeKOYHLCUZElsOIf23K/Q6e235XTF7L5VKHBBkm5Ar6rhQO3+oakFE6kuLQ2QjIjp5F vMrTJO+GHEfXWRfo2Icv1REGZY+pKdZ+06hwyeZp6D2GtfcNy67/F3K8KgT+O/aqzUsB gzvg== X-Forwarded-Encrypted: i=1; AJvYcCWlqr8H2au5BLc0lMh3Oc564KPtR2G14De5s6jIevUiDVTUgfyRdZsZb73PrBjgaJCrenBoeUS/k4hJN+ssBAW4TEq/LLVc8o37Gjdx2qE= X-Gm-Message-State: AOJu0YyavpWsyimTW7Uwvj5GoCyR628p/KawEbyJr2boEsu4eu9hrBH+ cw4/qENTE+kk1vp1E6oWV+dWAbu0GXCqMdVGPSgAx2hjQ/y9rv29xso2Drz6FQ9KIZGY/40ggwX B/kazpyj/sUaL6aHeul2uXWil1pOnI9c5BkxMk0J5nJJ5Y7TcGD1hRE0OP4zpVmcT X-Received: by 2002:a05:600c:5493:b0:426:6ee7:c05a with SMTP id 5b1f17b1804b1-4266ee7c253mr768395e9.15.1720437945918; Mon, 08 Jul 2024 04:25:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFleDfM0VAI2FqOfDLpFDYDHHTu1E1XX5kKYuAnqPX8YzewfdIeXDRmz5P8FtyDaahi97NdSQ== X-Received: by 2002:a05:600c:5493:b0:426:6ee7:c05a with SMTP id 5b1f17b1804b1-4266ee7c253mr768125e9.15.1720437945583; Mon, 08 Jul 2024 04:25:45 -0700 (PDT) Received: from pollux ([2a02:810d:4b3f:ee94:abf:b8ff:feee:998b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4264a1dda61sm162052725e9.19.2024.07.08.04.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 04:25:45 -0700 (PDT) Date: Mon, 8 Jul 2024 13:25:43 +0200 From: Danilo Krummrich To: Miguel Ojeda Cc: Andrew Ballance , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, mcgrof@kernel.org, russ.weight@linux.dev, ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, rust-for-linux@vger.kernel.org Subject: Re: [PATCH] rust: firmware: fix invalid rustdoc link Message-ID: References: <20240708090615.2267476-1-andrewjballance@gmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Jul 08, 2024 at 11:16:34AM +0200, Miguel Ojeda wrote: > On Mon, Jul 8, 2024 at 11:07 AM Andrew Ballance > wrote: > > > > rustdoc generates a link to a nonexistent file because of a extra quote > > > > Signed-off-by: Andrew Ballance > > Thanks for the patch! > > I guess this is meant for staging/rust-device, but I think this should > be a review comment here: Firmware and device abstractions were merged in driver-core-next. > > https://lore.kernel.org/rust-for-linux/20240618154841.6716-3-dakr@redhat.com/ > > Cheers, > Miguel >