* [PATCH] rust: re-order exports to fix rustfmt
@ 2024-09-30 1:09 Tudor Gheorghiu
2024-09-30 4:15 ` Dirk Behme
0 siblings, 1 reply; 3+ messages in thread
From: Tudor Gheorghiu @ 2024-09-30 1:09 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross
Cc: rust-for-linux, linux-kernel, Tudor Gheorghiu
In the recent rust-6.12 tag merge at 570172569238, the rbtree export was
added after the sizes export, thus breaking rustfmt's alphabetical
export ordering rules.
Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
---
rust/kernel/lib.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
index 22a3bfa5a9e9..b5f4b3ce6b48 100644
--- a/rust/kernel/lib.rs
+++ b/rust/kernel/lib.rs
@@ -44,8 +44,8 @@
pub mod page;
pub mod prelude;
pub mod print;
-pub mod sizes;
pub mod rbtree;
+pub mod sizes;
mod static_assert;
#[doc(hidden)]
pub mod std_vendor;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: re-order exports to fix rustfmt
2024-09-30 1:09 [PATCH] rust: re-order exports to fix rustfmt Tudor Gheorghiu
@ 2024-09-30 4:15 ` Dirk Behme
2024-09-30 5:09 ` Tudor Gheorghiu
0 siblings, 1 reply; 3+ messages in thread
From: Dirk Behme @ 2024-09-30 4:15 UTC (permalink / raw)
To: Tudor Gheorghiu, Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross
Cc: rust-for-linux, linux-kernel
On 30.09.2024 03:09, Tudor Gheorghiu wrote:
> In the recent rust-6.12 tag merge at 570172569238, the rbtree export was
> added after the sizes export, thus breaking rustfmt's alphabetical
> export ordering rules.
>
> Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
> ---
> rust/kernel/lib.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> index 22a3bfa5a9e9..b5f4b3ce6b48 100644
> --- a/rust/kernel/lib.rs
> +++ b/rust/kernel/lib.rs
> @@ -44,8 +44,8 @@
> pub mod page;
> pub mod prelude;
> pub mod print;
> -pub mod sizes;
> pub mod rbtree;
> +pub mod sizes;
> mod static_assert;
> #[doc(hidden)]
I think we have that in rust-fixes already:
https://github.com/Rust-for-Linux/linux/commit/ece207a83e464af710d641f29e32b7a144c48e79
Dirk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rust: re-order exports to fix rustfmt
2024-09-30 4:15 ` Dirk Behme
@ 2024-09-30 5:09 ` Tudor Gheorghiu
0 siblings, 0 replies; 3+ messages in thread
From: Tudor Gheorghiu @ 2024-09-30 5:09 UTC (permalink / raw)
To: Dirk Behme
Cc: Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, rust-for-linux, linux-kernel
On Mon, Sep 30, 2024 at 06:15:32AM +0200, Dirk Behme wrote:
> On 30.09.2024 03:09, Tudor Gheorghiu wrote:
> > In the recent rust-6.12 tag merge at 570172569238, the rbtree export was
> > added after the sizes export, thus breaking rustfmt's alphabetical
> > export ordering rules.
> >
> > Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
> > ---
> > rust/kernel/lib.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> > index 22a3bfa5a9e9..b5f4b3ce6b48 100644
> > --- a/rust/kernel/lib.rs
> > +++ b/rust/kernel/lib.rs
> > @@ -44,8 +44,8 @@
> > pub mod page;
> > pub mod prelude;
> > pub mod print;
> > -pub mod sizes;
> > pub mod rbtree;
> > +pub mod sizes;
> > mod static_assert;
> > #[doc(hidden)]
>
> I think we have that in rust-fixes already:
>
> https://github.com/Rust-for-Linux/linux/commit/ece207a83e464af710d641f29e32b7a144c48e79
>
> Dirk
>
You are correct! I didn't check rust-fixes, as I was working on
something else when I noticed this.
Thanks!
Have a great day!
Tudor
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-30 5:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 1:09 [PATCH] rust: re-order exports to fix rustfmt Tudor Gheorghiu
2024-09-30 4:15 ` Dirk Behme
2024-09-30 5:09 ` Tudor Gheorghiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).