From: Danilo Krummrich <dakr@kernel.org>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "Guilherme Giácomo Simões" <trintaeoitogc@gmail.com>,
rafael@kernel.org, ojeda@kernel.org, alex.gaynor@gmail.com,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, aliceryhl@google.com, mcgrof@kernel.org,
russ.weight@linux.dev, dakr@redhat.com, a.hindborg@kernel.org,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] device: rust: change the name function
Date: Mon, 30 Sep 2024 14:11:37 +0200 [thread overview]
Message-ID: <ZvqVedQhdyiWREcd@pollux> (raw)
In-Reply-To: <2024093044-emblaze-disrupt-d479@gregkh>
On Mon, Sep 30, 2024 at 01:35:09PM +0200, gregkh@linuxfoundation.org wrote:
>
> > /// While not officially documented, this should be the case for
> > any `struct device`.
> > - pub unsafe fn from_raw(ptr: *mut bindings::device) -> ARef<Self> {
> > + pub unsafe fn get_device(ptr: *mut bindings::device) -> ARef<Self> {
>
> With this change, nothing broke? Does nothing call this code yet? I
> thought the firmware interface did that, but I could be wrong...
The firmware code uses the `Device` structure, but it doesn't create a
reference from a raw pointer.
This function should probably only ever be called from bus abstractions. I
thought the PHY layer needed this urgently (which also was the reason we merged
it already), so I'd expect the PHY code to use it.
Though, they might just use `as_ref`.
- Danilo
next prev parent reply other threads:[~2024-09-30 12:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 13:38 [PATCH 2/2] device: rust: change the name function Guilherme Giácomo Simões
2024-09-30 11:35 ` gregkh
2024-09-30 11:50 ` Guilherme Giácomo Simões
2024-09-30 12:11 ` Danilo Krummrich [this message]
2024-09-30 12:28 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvqVedQhdyiWREcd@pollux \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=trintaeoitogc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).