From: Yutaro Ohno <yutaro.ono.418@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: rust-for-linux@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Danilo Krummrich" <dakr@redhat.com>,
"Valentin Obst" <kernel@valentinobst.de>
Subject: Re: [PATCH] rust: kernel: fix THIS_MODULE header path in ThisModule doc comment
Date: Mon, 21 Oct 2024 11:51:44 +0900 [thread overview]
Message-ID: <ZxXBwMOsNjtz1PD5@ohnotp> (raw)
In-Reply-To: <2024101926-crisply-immersion-5077@gregkh>
Hi Greg, thank you for reviewing.
On 10/19, Greg KH wrote:
> On Sat, Oct 19, 2024 at 06:52:27PM +0900, Yutaro Ohno wrote:
> > The doc comment for `ThisModule` incorrectly states the C header file
> > for `THIS_MODULE` as `include/linux/export.h`, while the correct path is
> > `include/linux/init.h`. This is because `THIS_MODULE` was moved in
> > commit 5b20755b7780 ("init: move THIS_MODULE from <linux/export.h> to
> > <linux/init.h>").
> >
> > Update the doc comment for `ThisModule` to reflect the correct header
> > file path for `THIS_MODULE`.
> >
> > Signed-off-by: Yutaro Ohno <yutaro.ono.418@gmail.com>
>
> This should get:
>
> Fixes: 5b20755b7780 ("init: move THIS_MODULE from <linux/export.h> to <linux/init.h>")
>
> added to it when merged.
You're right. I'll add in v2.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
Cheers,
Yutaro
prev parent reply other threads:[~2024-10-21 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 9:52 [PATCH] rust: kernel: fix THIS_MODULE header path in ThisModule doc comment Yutaro Ohno
2024-10-19 10:04 ` Greg KH
2024-10-21 2:51 ` Yutaro Ohno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxXBwMOsNjtz1PD5@ohnotp \
--to=yutaro.ono.418@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@redhat.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@valentinobst.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).