From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7218C38DF9; Tue, 19 Nov 2024 01:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731980038; cv=none; b=UjquZQiiV64T58QXMWJGJTS8flu+cRA9OcqKTUT+LY+qKnBxzphP65hLCQQtCnXpXjzDOIukXt2TDM0t80K9D+JAtFwlPL5pdIknro2PScueeeo9V+Ftzn7LWwNC4qEFOahEEuYa/s7NsVfYEoYFsOl+8FXlVZPNKEsiSsE3NLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731980038; c=relaxed/simple; bh=mNt8PlqqcC/OYquNFftD5zrdVAQF347e7lS7kQENIPk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IGHvV8v6g24DHP08bajX7p/qWUMPjI4cvlo1a/+ZVGwyxk7RN3jJRgUBhfbByAxPAalBl+D5iDvE5J861U4HYMCYS4li7B4E2FKxdq4enkOXNX/npNwYzNbfKOlHbtcqGaUozdIi+G48AMcA3jA2h1Chf8QcAUYdKXg8zO0/nQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Eem+nPyw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Eem+nPyw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BA7DC4CECC; Tue, 19 Nov 2024 01:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731980038; bh=mNt8PlqqcC/OYquNFftD5zrdVAQF347e7lS7kQENIPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eem+nPywW0S2PDt91tSJR5p0NMCU+bTT5JOtCmT14pE/aJodu5jgVPqbKYtMScBTO 4a6oEr0BIwqu7ctxPRVl4gmjUfKuyKWzV3GIlqflmoxzJTtyF3khU+bFKzkBa4W7xn uS/0+gnOstSaoY32KS80dPq19n77mZfH4F+fTO9puHA/NZT0q9IKxwGIOM8SNaQ3fT aEUjEhlu2kI833TKd+EX80pn6Ajw7GdGwNBKwigJWaQB70jF4DZV7h+WkWYW1nrFLT VhV6Ro96JpzGjR2ogkz0k1QY4DP8MjriuHWtibLjHrgQXjIoet+kamk0xEN0GtrJS2 CokaAdc0f2CMg== Date: Mon, 18 Nov 2024 17:33:56 -0800 From: Luis Chamberlain To: Matthew Maurer Cc: Lucas De Marchi , Lucas De Marchi , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Petr Pavlu , Sami Tolvanen , Daniel Gomez , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v8 2/3] modpost: Produce extended MODVERSIONS information Message-ID: References: <20241030-extended-modversions-v8-2-93acdef62ce8@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Nov 18, 2024 at 04:09:34PM -0800, Matthew Maurer wrote: > > Thinking about this some more, if we're going down enabling a new > > option, it seems to beg the question if the old *two* ksymtab sections > > could just be folded into the a new one where the "gpl only" thing > > becomes just one "column" as you call it. Reasons I ask, it seems like > > we're duplicating symbol names on ksymtab and for modeversions. Could > > you review this a bit? > > Short answer: We could do this, but I don't necessarily think it's a good idea. Thanks for your review on this. I agree the complexities you outline don't yet justify the churn. Luis