Rust for Linux List
 help / color / mirror / Atom feed
From: Manuel Ebner <manuelebnerli@mailbox.org>
To: Nicolas Schier <n.schier@fritz.com>
Cc: "Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH] v2 Docs: changes.rst: introduce optional column
Date: Fri, 04 Sep 2026 19:02:52 +0200	[thread overview]
Message-ID: <a2066238d2be3cfd36cd6ea3a7bf11206cb0a02a.camel@mailbox.org> (raw)
In-Reply-To: <20260904-stirring-zircon-frog-ea6949@l-nschier-aarch64>

On Fri, 2026-09-04 at 18:11 +0200, Nicolas Schier wrote:
> On Mon, Aug 31, 2026 at 05:25:22PM +0200, Manuel Ebner wrote:
> > The optional tag isn't obvious nor defined. Therefore replace with column.
> 
> Why do you throw away the 'Command to check the version' column?  

I would do this to get some space for the optional column and have
the version commands in ./scrips/ver_linux . See below.

> At 
> work, we have a script that uses these commands to check the actual 
> tooling versions.

Well, I don't want to break that.

> If there is a reason for change, please document it in the commit 
> message.

Will do.

> > Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> > ---
> >  Documentation/process/changes.rst | 84 +++++++++++++++----------------
> >  1 file changed, 42 insertions(+), 42 deletions(-)
> > 
> > diff --git a/Documentation/process/changes.rst b/Documentation/process/changes.rst
> > index b3fa980b63e3..905ac0f6cdc5 100644
> > --- a/Documentation/process/changes.rst
> > +++ b/Documentation/process/changes.rst
> > @@ -29,49 +29,49 @@ systems; obviously, if you don't have any PC Card hardware, for example,
> >  you probably do not need to concern yourself with pcmciautils.
> >  
> >  ====================== ===============  ========================================
> > -        Program        Minimal version       Command to check the version
> > +        Program        Minimal version  Required for 
> 
> Do you want to align the column headers to the left or center them?

I should have done this the proper way but i didn't.

> >  ====================== ===============  ========================================
> > -bash                   4.2              bash --version
> > ...
> > +bash                   4.2              
> > ...
> >  ====================== ===============  ========================================
> >  
> >  .. [#f1] Sphinx is needed only to build the Kernel documentation
> 
> I kind of like the "Required for" column w/ naming 
> concrete Kconfig symbols or envs like ARCH.  

Thanks, do you prefer your scripts working or the required for column? Maybe there
is space for both, when 'program' and 'Minimal version' get squished.
Would one of those arrangements not break your scripts?

>  ====================== ===============  ================  =======================
>          Program        Minimal version    Required for        Version Command
>  ====================== ===============  ================  =======================

OR
>  ====================== ===============  =======================  ================
>          Program        Minimal version      Version Command        Required for
>  ====================== ===============  =======================  ================

> I think it would be good to 
> get this a bit more complete, where possible.

I have only little clue about tooling, versions or Kconfig so I'll need some help with that.

Thanks
 Manuel 

> Kind regards,
> Nicolas

  reply	other threads:[~2026-09-04 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 15:16 [PATCH 0/4 v2] Docs: changes.rst: rework Manuel Ebner
2026-08-31 15:24 ` [PATCH 3/4] Docs: pt_BR, it_IT: changes.rst: copy table from english source Manuel Ebner
2026-08-31 15:25 ` [PATCH] v2 Docs: changes.rst: introduce optional column Manuel Ebner
2026-08-31 16:32   ` Miguel Ojeda
2026-09-04 16:11   ` Nicolas Schier
2026-09-04 17:02     ` Manuel Ebner [this message]
2026-09-01 10:03 ` [PATCH 0/4 v2] Docs: changes.rst: rework Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2066238d2be3cfd36cd6ea3a7bf11206cb0a02a.camel@mailbox.org \
    --to=manuelebnerli@mailbox.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=justinstitt@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=lossin@kernel.org \
    --cc=morbo@google.com \
    --cc=n.schier@fritz.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox