From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Boqun Feng <boqun.feng@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>
Subject: Re: [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl
Date: Mon, 26 Jun 2023 00:34:17 -0300 [thread overview]
Message-ID: <a79002ec-aa2d-1eec-58be-372c3b2a0efa@gmail.com> (raw)
In-Reply-To: <20230625232528.89306-1-boqun.feng@gmail.com>
On 6/25/23 20:25, Boqun Feng wrote:
> While there are default impls for these methods, using the respective C
> api's is faster. Currently neither the existing nor these new
> GlobalAlloc method implementations are actually called. Instead the
> __rust_* function defined below the GlobalAlloc impl are used. With
> rustc 1.71 these functions will be gone and all allocation calls will go
> through the GlobalAlloc implementation.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/68
> Signed-off-by: Björn Roy Baron <bjorn3_gh@protonmail.com>
> [boqun: add size adjustment for alignment requirement]
I think that this should go above Link and Signed-off-bys, although I'm
not sure if maintainers do it when is merged.
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
> Miguel, I fold my diff into Björn's original patch and make a v2, it
> relies on the other patch:
>
> https://lore.kernel.org/rust-for-linux/6e61f06f-2411-0bcb-926b-0a6927096f20@gmail.com/
>
> So this v2 (if all goes well) is targeted for v6.6, JFYI.
>
> v1 -> v2:
>
> * Add size adjustment for align requirement.
>
> [...]
Newbie question, aren't tabs in the commit message verboten?
Aside from those two nits everything else LGTM.
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
next prev parent reply other threads:[~2023-06-26 3:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 23:25 [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the GlobalAlloc impl Boqun Feng
2023-06-26 3:34 ` Martin Rodriguez Reboredo [this message]
2023-06-26 9:40 ` Miguel Ojeda
2023-06-26 13:11 ` Martin Rodriguez Reboredo
2023-06-28 10:07 ` Benno Lossin
2023-06-28 16:43 ` Gary Guo
2023-07-29 14:01 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a79002ec-aa2d-1eec-58be-372c3b2a0efa@gmail.com \
--to=yakoyoku@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).