rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Albin Babu Varghese <albinbabuvarghese20@gmail.com>
To: Benno Lossin <lossin@kernel.org>
Cc: rust-for-linux@vger.kernel.org
Subject: Re: [[PATCH]] rust/list: replace unwrap() with ? in doctest examples
Date: Mon, 26 May 2025 20:53:55 -0400	[thread overview]
Message-ID: <aDUNI6eaifgJx2B_@arch-box> (raw)
In-Reply-To: <DA5Y0QPY52WJ.DFA7YNSN2B2M@kernel.org>

Thank you, Benno and Miguel, for taking the time to review this patch.

> The subject of your email starts with `[[PATCH]]`, normally we use
> `[PATCH]` instead. Did you use `git send-email` and `git format-patch`?

I apologize for the inconsistency in the subject line. I did use both git
send-email and git format-patch when submitting. I believe the double brackets
were caused by a subject prefix I’d added in my email setup and only noticed
afterward. It’s working as intended now.
 
> Commit messages should be wrapped to a sensible column length such as 72
> characters.

> Also this is missing the motivation that newcomers might get the
> impression that calling `unwrap` is OK.
> 
> > Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> >
> 
> No need for blank lines in the taglist.

I’ll rewrite the commit message to wrap at 72 characters and remove the extra
blank tag lines.

-------
Thanks again,
Albin

      parent reply	other threads:[~2025-05-27  0:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-25 22:59 [[PATCH]] rust/list: replace unwrap() with ? in doctest examples Albin Babu Varghese
2025-05-26  8:18 ` Benno Lossin
2025-05-26 10:33   ` Miguel Ojeda
2025-05-26 20:28     ` Benno Lossin
2025-05-27  1:12       ` Albin Babu Varghese
2025-05-27  0:53   ` Albin Babu Varghese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDUNI6eaifgJx2B_@arch-box \
    --to=albinbabuvarghese20@gmail.com \
    --cc=lossin@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).