From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62911214229 for ; Wed, 28 May 2025 10:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748427616; cv=none; b=teMCUziZTvK8Te3qCh0+gXIE3l5u9xfqzrdfofbauLuJktAGpqCa4bV47ElhOSZwfBrwFEBAOmzxicsR9nUzvG5kjwy82Q33BM2Qw0n4+lxDTrLlsOTfvMwq5dJtEC6sBpMYxjZWKmQZWu2erh0lQtPFb0jbSbD6+EBJjNjWPdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748427616; c=relaxed/simple; bh=QVXvLr3GtA7cc1rTDq8wqrsCt69VXLlXgxESkQwMPGs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ZBUWyFivncKWE2hkJDETwav7n85w1D0Mi2TkLWuDUe/IVbpzWN7kt3m4uC6LGrl6TbMVphODT3PCKfN/LPGNeRKZwzV6nkzdgkIDhqxRuaM97gvLvLwdScXpqj93192Wdq6Avlsh4IfGKfNL8SJTfO1rNCuk5nM4+MUq6LNigTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=KJoSS04+; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KJoSS04+" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-43d4d15058dso32249655e9.0 for ; Wed, 28 May 2025 03:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1748427613; x=1749032413; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ZqTpKLT888ECG39NBheVQQY2QZ8sDTvoN58x2xm6E7Y=; b=KJoSS04+5nFceubjLn07ZmwFPgjJAPvZD2Ya8WqinsLMA23elwz8zz2ZwI3Ywwewdv quIbB1+ANRrSMqPeEZcaoF+YxuZ01Xs1fJO/eXHbsPPAtPtJYhpqYFAZ9m8WIklNr7u+ gy0KI2JQY+E8QtvkxK6P2HHDRTpNebxqt1CdJvG+6/BtJx21I4wNA3ZmIbGSaQq6871a +L2xArlSw9D6NLNxHknGZ1XsoJrzjQDJnr9fRitB0PPBBJDheR7slHCCAmpEoJlMX9Bp hzTfGqTlnU6L5/FcqEoP7C16k3ZITgudSHwO44RthEX45/iQaAWJ9zUA10n/vTtf+OSb 9dFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748427613; x=1749032413; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZqTpKLT888ECG39NBheVQQY2QZ8sDTvoN58x2xm6E7Y=; b=TzYSfUWQ1UC6k6dg2v6Tcezim4va/L29wzM5NIYxTXzyU3m3TNpZEc6Nnlgy9Mu0GK NBCPydZ1523cJPILdSijuYikyoLQTHrqqphp3h2JZM6SSpvGoNxssfC976B8dLDo2f9r c2ZWA5AEm0WVnAEqrBedGo0N095hZ4eL6yAe2GvgG0QSmr7JwQ+uwdgfIznKm8bZlQZC YdohhHIj/Wh/Xrf43H/D+p9Kpf8lkTT31YWjgSTo5VvqQBSXzuJGBpm7hnCGM+bW05ik hYsy2tlxXAgCMZsf2D//qmTwJ7fAT85LYKGZlPsg3gVpNYqHE7OpskMabq7JIFnAc34h 3MFA== X-Forwarded-Encrypted: i=1; AJvYcCWa+co4wuR0KNEIpVbxXZsirpZ1FRVyM+e2SwuJWcOClrifo6iePA+i3Duna5bfAyDrn00B+r5kMtIwsjSidg==@vger.kernel.org X-Gm-Message-State: AOJu0Ywnaf70xLNCQqFkrK5FNlolB+F8Suz3zKX29PCAUcPS0W0/OBj2 js15VerMHbtVYb8QdRhOpWrlktwW5R2OktKmFsExyvZhV8Oa8mYHqsZxZ3l+d58zetcv6s+5nA2 6XVXju8OlgS5mLRa7OA== X-Google-Smtp-Source: AGHT+IFbZP87yhpd+A5UORuRl+efDd9mhI47Db4pLu1nsC4kPmFxtELld4jQWoKyvlreBoGWn167CcDJWgZNgZI= X-Received: from wmbdv21.prod.google.com ([2002:a05:600c:6215:b0:450:5dbe:5f11]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a13:b0:43d:160:cd9e with SMTP id 5b1f17b1804b1-44c91fbb448mr159238185e9.17.1748427612802; Wed, 28 May 2025 03:20:12 -0700 (PDT) Date: Wed, 28 May 2025 10:20:10 +0000 In-Reply-To: <20250527204636.12573-2-pekkarr@protonmail.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250527204636.12573-1-pekkarr@protonmail.com> <20250527204636.12573-2-pekkarr@protonmail.com> Message-ID: Subject: Re: [PATCH 2/2] rust: file: improve safety comments From: Alice Ryhl To: Pekka Ristola Cc: Alexander Viro , Christian Brauner , Miguel Ojeda , Alex Gaynor , Jan Kara , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , linux-fsdevel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, May 27, 2025 at 08:48:59PM +0000, Pekka Ristola wrote: > Some of the safety comments in `LocalFile`'s methods incorrectly refer to > the `File` type instead of `LocalFile`, so fix them to use the correct > type. > > Also add missing Markdown code spans around lifetimes in the safety > comments, i.e. change 'a to `'a`. > > Link: https://github.com/Rust-for-Linux/linux/issues/1165 > Signed-off-by: Pekka Ristola Reviewed-by: Alice Ryhl