Re: [PATCH v4 1/3] rust: implement `Wrapper<T>` for `Opaque<T>`

[Danilo Krummrich <dakr@kernel.org>]

On Fri, May 30, 2025 at 10:53:21PM +0200, Christian Schrefl wrote:
> On 30.05.25 10:46 PM, Christian Schrefl wrote:
> > Moves the implementation for `pin-init` from an associated function
> > to the trait function of the `Wrapper` trait and extends the
> > implementation to support pin-initializers with error types.
> > 
> > Adds a use for the `Wrapper` trait in `revocable.rs`, to use the new
> > `pin-init` function. This is currently the only usage in the kernel.
> > 
> > Reviewed-by: Gerald Wisböck <gerald.wisboeck@feather.ink>
> > Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> > Reviewed-by: Benno Lossin <lossin@kernel.org>
> > Signed-off-by: Christian Schrefl <chrisi.schrefl@gmail.com>
> > ---
> 
> Danilo, FYI this is basically a patch from my `UnsafePinned`
> series [0] that I've used instead of your patch [1] that does something similar.
> (I've only dropped `the call is infallible` from the safety
> comment like in your patch since I missed that before).
> 
> Let me know if you want me to handle this any different.

No, that's fine, I wasn't aware of this patch, let's go with this one then.

	Reviewed-by: Danilo Krummrich <dakr@kernel.org>

> [0]: https://lore.kernel.org/rust-for-linux/20250511-rust_unsafe_pinned-v4-2-a86c32e47e3d@gmail.com/
> [1]: https://lore.kernel.org/rust-for-linux/20250530142447.166524-2-dakr@kernel.org/