From: Danilo Krummrich <dakr@kernel.org>
To: Igor Korotin <igor.korotin.linux@gmail.com>
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, rafael@kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-acpi@vger.kernel.org,
boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com,
benno.lossin@proton.me, a.hindborg@kernel.org,
aliceryhl@google.com, tmgross@umich.edu, lenb@kernel.org,
wedsonaf@gmail.com, viresh.kumar@linaro.org, alex.hung@amd.com,
dingxiangfei2009@gmail.com
Subject: Re: [PATCH v5 4/6] rust: platform: Add ACPI match table support to `Driver` trait
Date: Wed, 11 Jun 2025 23:28:57 +0200 [thread overview]
Message-ID: <aEn1GbRJpUwMd7xc@cassiopeiae> (raw)
In-Reply-To: <20250611175121.803370-1-igor.korotin.linux@gmail.com>
On Wed, Jun 11, 2025 at 06:51:21PM +0100, Igor Korotin wrote:
> @@ -162,7 +178,10 @@ pub trait Driver: Send {
> type IdInfo: 'static;
>
> /// The table of OF device ids supported by the driver.
> - const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>>;
> + const OF_ID_TABLE: Option<of::IdTable<Self::IdInfo>> = None;
This change is fine, but it should be a separate patch.
next prev parent reply other threads:[~2025-06-11 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 17:40 [PATCH v5 0/6] rust: Add ACPI match table support for Rust drivers Igor Korotin
2025-06-11 17:44 ` [PATCH v5 1/6] rust: acpi: add `acpi::DeviceId` abstraction Igor Korotin
2025-06-11 17:46 ` [PATCH v5 2/6] rust: driver: Consolidate `Adapter::of_id_info` methods using `#[cfg]` Igor Korotin
2025-06-11 17:48 ` [PATCH v5 3/6] rust: driver: Add ACPI id table support to Adapter trait Igor Korotin
2025-06-11 17:51 ` [PATCH v5 4/6] rust: platform: Add ACPI match table support to `Driver` trait Igor Korotin
2025-06-11 21:28 ` Danilo Krummrich [this message]
2025-06-11 17:53 ` [PATCH v5 5/6] rust: cpufreq: Remove unnecessary `of` dependency in cpufreq example Igor Korotin
2025-06-11 21:40 ` Danilo Krummrich
2025-06-11 17:56 ` [PATCH v5 6/6] samples: rust: add ACPI match table example to platform driver Igor Korotin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEn1GbRJpUwMd7xc@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=alex.hung@amd.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dingxiangfei2009@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=igor.korotin.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).