From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2532248898 for ; Thu, 12 Jun 2025 17:49:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749750583; cv=none; b=ayyLduDUh1TmTOEYvSbgu/0VUunIKqk9UW7JYSp6lRf0MIgMq4DizP3KdTR1feMYkwIjqsdo6lXZNqF5YE2lDu7LuqtJgwUDh6dyblvVuBi7ecXXB6jFpP7fpx/tB9iLkaywH+GY3Q+Kl73xnQe7RohyTfirtCFHg1iPSB5cZWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749750583; c=relaxed/simple; bh=bdOP/dpPl/UU10GsQOaLEBHx9DtJHd4giISmHR0qzJg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ob0LjKKa6aDutl2oTtzh2LrmuOlb/6Fk4YrHTx0Ie/LmUaaVJf3waDLgHGcECGcLq8uy0edV09j22lz/8bvFYsqt0kpNuEy+tScwm0YjpIVI9nohRfkrH9pO1btjM805iiHKDwCyHXNLu82ZZ1imWZcpb2cKlQGNO1kQDXS565s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=1w6eSTYw; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="1w6eSTYw" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-747fc7506d4so1294013b3a.0 for ; Thu, 12 Jun 2025 10:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1749750581; x=1750355381; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kKudhM6GP7ucCr8LJ/xGTzdQhmTfuZa6CNBowxM0Kt8=; b=1w6eSTYwQvXrJY/0WPcquBS4DdRzRTQpxxUCCO+W4G1dFRCmLqRj/Er48RRbHWKqtP 8Ax2OzIAjbH0qcmENWxE4eqg9b1/MzZmDMU8ahfxIFXBb0RDtVMuD5d6UXwzueoMWb1n qqd3xoau/DNHSYV+7JEfbPPfoW2/hWGEiZaP97GSJNGmpZJp0x0v2ZJCHpqmQF/GYMxn 6Sn5b1a7DxDKAzMX8ckrIKTeIAmAgK8LrLsVNdFgu3tUAgplHMJG3cvTOKG4soriqlVu w9iUeXl4FlGW8obhTJzteIfyWO/Py78ULzaNmGT9aZhMa6HzxEKCpR//fzz5xGjlyry6 S1jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749750581; x=1750355381; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kKudhM6GP7ucCr8LJ/xGTzdQhmTfuZa6CNBowxM0Kt8=; b=Nt04zVnlsamEQNZ6INf41jyijgrVSBf/dz77WBN4nMIRZ/Jh7nh8r7Tfdlm+ejRRe4 012NY5I5UCDhOGUQFMLlVijT1n5r689dbyt1tFY4IFgT9xcS7bIRDVWh/MnU4Kuld0wn i9IgylOzUjpzCGfIX6pmGBnutJEjxqDF1MkJEi1FBevGA0D6P2wu45n3Mgi+Zf+q6djl iBWjtDbBZEnJlDB9eRwW2WSpb3Oagzr6bpsNe0MVYeZ6I1fPfNOFXssmR8zOr2H9TF4A YzL8idalKNnHwErBtGUlAicFcv/N7B8aW3Fjyq0YvP1V4RkSxxx0LASYvR0X/cfHq+nw zOnw== X-Forwarded-Encrypted: i=1; AJvYcCUVnaoVapFXQSZWMwqCnHGFPE2o3I2Wun2UpMX+lodTofN3zbTjtjHXFcLe8vBB5MPWqcCP0CtEpyzM09BuMg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz8o1yrqtU8Bkv/sGohkgi6iArQtiPPEdx+d2aNF43RYnaeizyN 7taJrdEac1xqO/OzB5oyEOZS3/UYeJ25mk1RZhUgV8ZfLVahDul4vqr8F3j6rllVr4Y= X-Gm-Gg: ASbGncsZ9TCFT3r/TRXD0VGKrq5ciZ0VclU2htL1zJMges1m+jWEW5l279Ex1ykPxxd Lu+Ee4CfMMd8hWcmT+9VyKzCQsewkkEQowgdYtOL2q6T1BdSjLkhM3NRhNLh2m62DUmBYfDF3He 4FagwJo1uO2OgOrqwebXW386QOOXaqInS3eq3J9f0pWzk7eMkLcSu8kXOCKQgLryxnkqpVMeRxG dezxBBsU6EhqwO2PaPZHIvQWOLqK5UJykWoFVyo8tdL3gsU5NEAqsvOsZAQ5UOxCU24xoYg2DUu winPRhEvQPvxDdxyD+xToToE32/HJv5cLXpVkn45wLFsvH8GCR+0CcJO3/4xovjASmVoX8C/qg= = X-Google-Smtp-Source: AGHT+IHLquFrw79+co4boFO8pJOfM9btk60nayGRQuNX/0ZumrQqIBCAkSYORT1Ip62N3F8udvKXLg== X-Received: by 2002:a05:6a00:984:b0:739:50c0:b3fe with SMTP id d2e1a72fcca58-7488f6cb9b2mr295006b3a.8.1749750581050; Thu, 12 Jun 2025 10:49:41 -0700 (PDT) Received: from x1 (97-120-245-201.ptld.qwest.net. [97.120.245.201]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748809eb146sm1837808b3a.109.2025.06.12.10.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jun 2025 10:49:40 -0700 (PDT) Date: Thu, 12 Jun 2025 10:49:38 -0700 From: Drew Fustini To: Michal Wilczynski Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Benno Lossin , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 0/7] Rust Abstractions for PWM subsystem with TH1520 PWM driver Message-ID: References: <20250610-rust-next-pwm-working-fan-for-sending-v2-0-753e2955f110@samsung.com> <6ca6016e-3b17-48a0-ad8d-bb05317aa100@samsung.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jun 12, 2025 at 03:27:09PM +0200, Michal Wilczynski wrote: > > > On 6/12/25 07:01, Uwe Kleine-König wrote: > > Hello Drew, > > > > On Wed, Jun 11, 2025 at 04:52:22PM -0700, Drew Fustini wrote: > >> I also enabled the pwm fan driver. However, there is a probe failure: > >> > >> [ 1.250921] pwm-fan pwm-fan: Failed to configure PWM: -524 > >> [ 1.256546] pwm-fan pwm-fan: probe with driver pwm-fan failed with error -524 > > > > 524 = ENOTSUPP, so it seems the request had duty_offset > 0. Does your > > fan use PWM_POLARITY_INVERTED? If so, try without that flag. If your fan > > really needs an inverted PWM this of course makes fan control buggy. > > With the next revision it should work fine (as a duty_offset > 0 should > > get rounded down to 0). > > Since we're running the same DT, the polarity shouldn't be inverted. I > see you have CONFIG_PWM_DEBUG=y enabled, which is most likely the reason > the probe fails. Thanks, I've disabled that options and the probe completes okay. The fan is now spinning :) Drew