rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: Vitaly Wool <vitaly.wool@konsulko.se>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, Uladzislau Rezki <urezki@gmail.com>,
	Alice Ryhl <aliceryhl@google.com>,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v6 3/4] rust: add support for NUMA ids in allocations
Date: Fri, 27 Jun 2025 20:36:11 +0200	[thread overview]
Message-ID: <aF7km7nm9ggoj2AW@pollux> (raw)
In-Reply-To: <20250627181638.2081102-1-vitaly.wool@konsulko.se>

On Fri, Jun 27, 2025 at 08:16:38PM +0200, Vitaly Wool wrote:
> Add support for specifying NUMA ids in Rust allocators as an Option
> (i. e. providing `None` as nid corresponds to NUMA_NO_NODE). To do
> this, modify ReallocFunc to use the new extended realloc primitives
> from the C side of the kernel (i. e. k[v]realloc_node/vrealloc_node)
> and add the new function alloc_node to the Allocator trait while
> keeping the existing one (alloc) for backward compatibility.
> 
> This will allow to specify node to use for allocation of e. g.
> {KV}Box, as well as for future NUMA aware users of the API.
> 
> Signed-off-by: Vitaly Wool <vitaly.wool@konsulko.se>

Did you see [1]? I can't see the feedback being addressed.

[1] https://lore.kernel.org/lkml/aF5-a-bUp1pD5tiS@pollux/

  reply	other threads:[~2025-06-27 18:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-27 18:15 [PATCH v5 0/4] support large align and nid in Rust allocators Vitaly Wool
2025-06-27 18:16 ` [PATCH v6 1/4] mm/vmalloc: allow to set node and align in vrealloc Vitaly Wool
2025-06-27 18:16 ` [PATCH v6 2/4] mm/slab: allow to set node and align in k[v]realloc Vitaly Wool
2025-06-27 18:16 ` [PATCH v6 3/4] rust: add support for NUMA ids in allocations Vitaly Wool
2025-06-27 18:36   ` Danilo Krummrich [this message]
2025-06-27 19:42     ` Vitaly Wool
2025-06-27 18:16 ` [PATCH v6 4/4] rust: support large alignments " Vitaly Wool
2025-06-27 18:37   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aF7km7nm9ggoj2AW@pollux \
    --to=dakr@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=urezki@gmail.com \
    --cc=vitaly.wool@konsulko.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).