From: Beata Michalska <beata.michalska@arm.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: ojeda@kernel.org, alex.gaynor@gmail.com, aliceryhl@google.com,
daniel.almeida@collabora.com, boqun.feng@gmail.com,
gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu, alyssa@rosenzweig.io,
lyude@redhat.com, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm: nova-drm: Update ioctl handlers to drop Opaque usage
Date: Tue, 24 Jun 2025 13:09:12 +0200 [thread overview]
Message-ID: <aFqHWOl0XcDdOrlN@arm.com> (raw)
In-Reply-To: <0ba4c988-194a-46f6-8e5d-b8fbc95a3eb8@kernel.org>
On Tue, Jun 24, 2025 at 11:59:25AM +0200, Danilo Krummrich wrote:
> On 6/24/25 11:32 AM, Beata Michalska wrote:
> > From: Danilo Krummrich <dakr@kernel.org>
> >
> > Following the removal of `Opaque<T>` for ioctl arguments in the DRM
> > framework, this patch updates the affected driver code to use typed
> > references directly.
> >
> > Signed-off-by: Danilo Krummrich <dakr@kernel.org>
> > Signed-off-by: Beata Michalska <beata.michalska@arm.com>
>
> It's very kind you want to attribute the shared diff with a separate patch, but
> you have to include this change into patch 1 ("rust: drm: Drop the use of Opaque
> for ioctl arguments"), otherwise it still breaks the build intermediately.
>
It is not so uncommon to send such changes in separate patches, to clearly
distinguish the changes, as long as whole series preserves the build.
That said, I can still send those as a single patch if that is the requirement.
---
BR
Beata
> Please feel free to just include the change in your patch -- no need for any
> attribution as far as I'm concerned. :)
next prev parent reply other threads:[~2025-06-24 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 9:31 [PATCH v2 0/2] Drop Opaque from IOCTL args Beata Michalska
2025-06-24 9:31 ` [PATCH v2 1/2] rust: drm: Drop the use of Opaque for ioctl arguments Beata Michalska
2025-06-24 9:32 ` [PATCH v2 2/2] drm: nova-drm: Update ioctl handlers to drop Opaque usage Beata Michalska
2025-06-24 9:59 ` Danilo Krummrich
2025-06-24 11:09 ` Beata Michalska [this message]
2025-06-24 11:20 ` Danilo Krummrich
2025-06-24 21:23 ` Beata Michalska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFqHWOl0XcDdOrlN@arm.com \
--to=beata.michalska@arm.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=alyssa@rosenzweig.io \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).