From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 43A112580E1 for ; Tue, 24 Jun 2025 21:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750800206; cv=none; b=D/XTvURIgLl+/YJxtXVfh0n4QsX6tozQUToZ0yCQv8wpN66k+wMNLb0fjNgr6RyOqAQAdehrY+hhtAhTIJl9JxixpMMdlAsZm0Vp3Q4VivxLYC2jXaGo0ZNAzWu+s69awYyEDDr7XDYCMUYBF9P2cZYuOHgSqp2v74EKFNss+is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750800206; c=relaxed/simple; bh=XibSCvtqYwj7TO9EBRhCbEfOeFMjQl6BOcBuRT50gQ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=h74J137sdftAf8ozL6/3ajKJY297/LRMivJJzsIpNcd8YlZNMRXPsTT54zIgE/8yHFAYFtmqvGUsHQ/Ryjjcdb/B4V/603hneFv8m5UpQ4YdLklQ9KXChRqiqVEaEupGeT/ctvdfaUO974UEfAIvQUUCL0Oz8MhkGonNzjL8BZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7343F113E; Tue, 24 Jun 2025 14:23:06 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B23EF3F58B; Tue, 24 Jun 2025 14:23:19 -0700 (PDT) Date: Tue, 24 Jun 2025 23:23:16 +0200 From: Beata Michalska To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, aliceryhl@google.com, daniel.almeida@collabora.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, tmgross@umich.edu, alyssa@rosenzweig.io, lyude@redhat.com, rust-for-linux@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 2/2] drm: nova-drm: Update ioctl handlers to drop Opaque usage Message-ID: References: <20250624093200.812812-1-beata.michalska@arm.com> <20250624093200.812812-3-beata.michalska@arm.com> <0ba4c988-194a-46f6-8e5d-b8fbc95a3eb8@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jun 24, 2025 at 01:20:51PM +0200, Danilo Krummrich wrote: > On Tue, Jun 24, 2025 at 01:09:12PM +0200, Beata Michalska wrote: > > On Tue, Jun 24, 2025 at 11:59:25AM +0200, Danilo Krummrich wrote: > > > On 6/24/25 11:32 AM, Beata Michalska wrote: > > > > From: Danilo Krummrich > > > > > > > > Following the removal of `Opaque` for ioctl arguments in the DRM > > > > framework, this patch updates the affected driver code to use typed > > > > references directly. > > > > > > > > Signed-off-by: Danilo Krummrich > > > > Signed-off-by: Beata Michalska > > > > > > It's very kind you want to attribute the shared diff with a separate patch, but > > > you have to include this change into patch 1 ("rust: drm: Drop the use of Opaque > > > for ioctl arguments"), otherwise it still breaks the build intermediately. > > > > > It is not so uncommon to send such changes in separate patches, to clearly > > distinguish the changes, as long as whole series preserves the build. > > That said, I can still send those as a single patch if that is the requirement. > > I think it is very uncommon; the general rule is that no patch should ever break > the build. > Noted. > From [1]: > > "When dividing your change into a series of patches, take special care to ensure > that the kernel builds and runs properly after each patch in the series. > Developers using `git bisect` to track down a problem can end up splitting your > patch series at any point; [...]" > > [1] https://docs.kernel.org/process/submitting-patches.html#separate-your-changes > > > > Please feel free to just include the change in your patch -- no need for any > > > attribution as far as I'm concerned. :)