From: Boqun Feng <boqun.feng@gmail.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benno Lossin" <lossin@kernel.org>
Subject: Re: [PATCH v2] workqueue: rust: add delayed work items
Date: Thu, 10 Jul 2025 09:30:21 -0700 [thread overview]
Message-ID: <aG_qnYSu4DU5xnP1@Mac.home> (raw)
In-Reply-To: <aG-7402hh4CCN7vh@google.com>
On Thu, Jul 10, 2025 at 01:10:59PM +0000, Alice Ryhl wrote:
[...]
> >
> >
> > unsafe { Opaque::cast_from(&raw const (*ptr).dwork) };
> >
> > > + // SAFETY: The caller promises that the pointer is aligned and not dangling.
> > > + let wrk: *mut bindings::work_struct = unsafe { core::ptr::addr_of_mut!((*dw).work) };
> >
> > Ditto.
>
> The rest of the file still uses addr_of!. I think we should stay
> consistent. We can update the entire file in one go.
>
Sounds good. Thanks!
Regards,
Boqun
> Alice
next prev parent reply other threads:[~2025-07-10 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-27 9:38 [PATCH v2] workqueue: rust: add delayed work items Alice Ryhl
2025-06-27 16:55 ` Tejun Heo
2025-06-27 17:43 ` Boqun Feng
2025-07-10 13:10 ` Alice Ryhl
2025-07-10 16:30 ` Boqun Feng [this message]
2025-06-27 18:39 ` Boqun Feng
2025-07-10 13:12 ` Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aG_qnYSu4DU5xnP1@Mac.home \
--to=boqun.feng@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tj@kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).