rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Danilo Krummrich <dakr@kernel.org>
To: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc: linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>
Subject: Re: [PATCH] rust: pci: fix documentation related to Device instances
Date: Sat, 5 Jul 2025 13:14:18 +0200	[thread overview]
Message-ID: <aGkJCix2VPaawyP-@pollux> (raw)
In-Reply-To: <20250629055729.94204-2-sergeantsagara@protonmail.com>

On Sun, Jun 29, 2025 at 05:57:56AM +0000, Rahul Rameshbabu wrote:
> Device instances in the pci crate represent a valid struct pci_dev, not a struct
> device.
> 
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>

This commit has two checkpatch warnings, can you please fix them, add a 'Fixes:'
tag and send a v2?

  parent reply	other threads:[~2025-07-05 11:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-29  5:57 [PATCH] rust: pci: fix documentation related to Device instances Rahul Rameshbabu
2025-06-29  7:14 ` Wren Turkal
2025-07-05  7:05   ` Rahul Rameshbabu
2025-07-05 11:11   ` Danilo Krummrich
2025-06-29  7:15 ` Wren Turkal
2025-06-29  7:20   ` Wren Turkal
2025-07-05 11:14 ` Danilo Krummrich [this message]
2025-07-06  4:02   ` Rahul Rameshbabu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aGkJCix2VPaawyP-@pollux \
    --to=dakr@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sergeantsagara@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).