From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4635E1E2602 for ; Fri, 15 Aug 2025 08:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755245850; cv=none; b=tyPN4jdXBDdk26R2AoruyEqzd2SN/qTPQHlqRUjKgeY8XvunYIvBki3yU+bPe9S5Y6P90A2tYi86KK0AWtwC0p6y1DmPH1TNM/WLdW6/XG1cqu9G/6+7gJTHcMUhLyKZ/JGFmiAX5hSEZ8RpESAjX/qzYW1+8CVwC5gp0yrjj30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755245850; c=relaxed/simple; bh=cOa7ZuyMM82PjkOXOzWct+P+y+EyW08Q69FZEGbX7io=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HkVbDWlFNC62JiAhxFf+5YAJIF5MBqeDw1jMpXOqS3dyEBUTE5LabNIF9gIJEUMILzraeF6+KVO+wYEn0YgT6FcIi7wOmZWRga+5WKdkVyFW+O/b3J0qbqBcMFD58NcHvbaDx8T/iRt4L/MLtf5Gn9EdCwe1y8u3e/GqTUtqucY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1qQs8Adv; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1qQs8Adv" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-45a1b0bd6a9so7190455e9.2 for ; Fri, 15 Aug 2025 01:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755245847; x=1755850647; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=u7bS7eW1yyQNa2vjGE9jPA8jEP8yN9eArEpHZlY5uGY=; b=1qQs8AdvjSzc6vK3k8Ms4fJR6K3N+u1XWhCF/XH6RxXqP+4kn1fmIzlghpgYfibyan 5AmfrBlJtSgc+d66BtE+M3ELB9riZn+7zlV/RCImmP6xkiw13PBYa2YnfZFsHzX0JeRg 8fKUqKkxdFk1Of/DVMDg70KYlSpqtUZb8TVx+ph40B3p4xSnwC0W5H6TiFwj7bLR+y10 mf5pGQ16kmlCzsbi02/0Do/pPIn+h1vnVk1DeFXj9L8KgkrvYQlqlqSnvLlmQQgmOt3v CuE5yHyQjMifpx9OUpWtiJvARSyOA/cRsys1Jnhc4oJV//6ohB+GT2RnpG670WQp3AYC Wf/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755245847; x=1755850647; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u7bS7eW1yyQNa2vjGE9jPA8jEP8yN9eArEpHZlY5uGY=; b=h0RBLMVdMPjtn5MHyTsPaoSLTS0ugPkZsGyY06C/Uib7cig5u7MZVQXoJswTNpCOCG vd+Sr7rRAMO5CB2cHyiXXqgK6aATC0JkiQK9YDT0Efb/Azq9IQYow6aleCUJzIuCBZ+i 7j4eNFOLFsMXaGVSc896DLBknJo2j43/76wy0y8FWlW8/bohC010P1/bTrHsAQhehoTe cuW/O9LfCAgItEJN7V5WtoC4fs6QrZO7vzfz7uOsG6YkryLPZBSEB4SU3Ncc3QJyymsy rDdTQBNCRmeOjMIUQgr1G/xxbXRkPLq9b8qJiDEAQ/pWFiTZR0UiJKmNXzPdONLOJnle DtcA== X-Forwarded-Encrypted: i=1; AJvYcCVXsko1jcfRHiw1B4mMj+WgSzgIDCBSsv4AYHMj0QkHmO+hwPQjokNaIBHZ819ZLFH5erQevClOKBM9RHwMrw==@vger.kernel.org X-Gm-Message-State: AOJu0Yyzx02dQ7HVocaQaKrLNWKMnkg2mspO8hoFL2S1C82bup26YRt9 oMimZkFY0tJRoWZRKePGMuA45cADOeUXeww/eDLclu5yfjjuRGQLbINP0Ym4oszpd1TEzFSmcZu W/nFNsN2CGg2kvQ2fzQ== X-Google-Smtp-Source: AGHT+IE/XcsHqhKTw9p5m5wNvEeLl/SDxmW8eaN5RJoJy1+RidvD8zgIZUVdDHrA8R2xfPTnhYekH16BlPrZfCE= X-Received: from wmbdv24.prod.google.com ([2002:a05:600c:6218:b0:459:d8e5:aead]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:474f:b0:456:285b:db24 with SMTP id 5b1f17b1804b1-45a21854c6fmr8684195e9.28.1755245847539; Fri, 15 Aug 2025 01:17:27 -0700 (PDT) Date: Fri, 15 Aug 2025 08:17:26 +0000 In-Reply-To: <20250815-rnull-up-v6-16-v5-14-581453124c15@kernel.org> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250815-rnull-up-v6-16-v5-0-581453124c15@kernel.org> <20250815-rnull-up-v6-16-v5-14-581453124c15@kernel.org> Message-ID: Subject: Re: [PATCH v5 14/18] rnull: enable configuration via `configfs` From: Alice Ryhl To: Andreas Hindborg Cc: Boqun Feng , Miguel Ojeda , Alex Gaynor , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Trevor Gross , Danilo Krummrich , Jens Axboe , Breno Leitao , linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Fri, Aug 15, 2025 at 09:30:49AM +0200, Andreas Hindborg wrote: > Allow rust null block devices to be configured and instantiated via > `configfs`. > > Signed-off-by: Andreas Hindborg Reviewed-by: Alice Ryhl > +impl NullBlkDevice { > + fn new( > + name: &CStr, > + block_size: u32, > + rotational: bool, > + capacity_mib: u64, > + ) -> Result> { > + let tagset = Arc::pin_init(TagSet::new(1, 256, 1), flags::GFP_KERNEL)?; GFP_KERNEL is in the prelude. Alice